From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FDDDC43217 for ; Thu, 1 Dec 2022 13:41:29 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id DB9E23CC4B9 for ; Thu, 1 Dec 2022 14:41:25 +0100 (CET) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id D4CC33CC470 for ; Thu, 1 Dec 2022 14:41:15 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 489251BE9BA8 for ; Thu, 1 Dec 2022 14:41:14 +0100 (CET) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 23E311FD8F; Thu, 1 Dec 2022 13:41:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1669902074; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zp82etR4AoB9/n40LxH/kR5etus3dHh06Ta8bdRLjdw=; b=ZCeHpIVKS+t8X7owTlnaBK2VGL5tlKf2A/XQy9jnjjnvpHNJXjm8pNk7OjVTWtV3PY651L u057nN6LnuTitZm7s+jzi49xoCXeIqgj/Gxp73bCMYSgF4JX5YcgpiLXSgm4lROZ3WB7Ol dj3alFzaD9bMbpB9wXIp6QrSTK7xv20= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1669902074; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zp82etR4AoB9/n40LxH/kR5etus3dHh06Ta8bdRLjdw=; b=1E76tZ3R/x5lKseMYYtnHpaHZJkBVSTM5H9edLbKVby5RTqge4Y0sN7AsRdN3JxXEhSLL1 CxiJdhCuRu3AggBw== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 12BC11320E; Thu, 1 Dec 2022 13:41:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id OYr0A/quiGNOGQAAGKfGzw (envelope-from ); Thu, 01 Dec 2022 13:41:14 +0000 Date: Thu, 1 Dec 2022 14:42:33 +0100 From: Cyril Hrubis To: Zhao Gongyi Message-ID: References: <20221201025141.71227-1-zhaogongyi@huawei.com> <20221201025141.71227-2-zhaogongyi@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221201025141.71227-2-zhaogongyi@huawei.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 1/2] lib/safe_macros: Add SAFE_STRTOF X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > +float safe_strtof(const char *file, const int lineno, > + void (cleanup_fn) (void), char *str, > + float min, float max) > +{ > + float rval; > + char *endptr; > + > + errno = 0; > + rval = strtof(str, &endptr); > + > + if ((errno == ERANGE) || (rval == 0) > + || (rval == HUGE_VAL) || (rval == -HUGE_VAL)) { This does not look right, supposedly the ERANGE is only set on overflow, and the rval is not guaranteed to be exact on underflow. Also rval == 0 is a valid result. We do zero errno above so I would just do: if (errno) { tst_brkm_(...); return rval; } > + tst_brkm_(file, lineno, TBROK | TERRNO, cleanup_fn, > + "strtof(%s) failed", str); > + return rval; > + } > + > + if (rval > max || rval < min) { > + tst_brkm_(file, lineno, TBROK, cleanup_fn, > + "strtof(%s): %f is out of range %f - %f", > + str, rval, min, max); > + return 0; > + } > + > + if (endptr == str || (*endptr != '\0' && *endptr != '\n')) { > + tst_brkm_(file, lineno, TBROK, cleanup_fn, > + "Invalid value: '%s'", str); > + return 0; > + } > + > + return rval; > +} Otherwise it looks good. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp