From: Petr Vorel <pvorel@suse.cz>
To: zhaogongyi <zhaogongyi@huawei.com>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH] config.mk.in: build.sh: Add -Wno-missing-field-initializers to CFLAGS
Date: Fri, 9 Dec 2022 10:50:50 +0100 [thread overview]
Message-ID: <Y5ME+qWykgu7PYoV@pevik> (raw)
In-Reply-To: <f276dc67c7234650835e3b859ec81204@huawei.com>
> Hi!
> > Hi!
> > > Add CFLAGS -Wno-missing-field-initializers to suppress the compilation
> > > warnings like:
> > > autogroup01.c:87:1: warning: missing initializer for field
> > > ‘needs_cmds’ of ‘struct tst_test’ [-Wmissing-field-initializers] };
> > > ^ In file included from autogroup01.c:21:0:
> > > ../../../../include/tst_test.h:324:21: note: ‘needs_cmds’ declared here
> > > const char *const *needs_cmds;
> > This is actually caused by a gcc bug that has been already fixed see:
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84685
> Thank you for your notice.
> > And I do not think that it's a good idea to work around gcc warnings in our
> > build system.
It's just matter of time when old gcc passes away.
> I haven't paid attention to other warning messages now. Maybe they should be ignored as well.
Most of the warnings are valid and should be fixed. That takes time, but we all
slowly work on it. Anyway, warning are here for a reason, I prefer to have false
positives than lost valid warning.
Kind regards,
Petr
> Regards,
> Gongyi
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-12-09 9:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 1:08 [LTP] [PATCH] config.mk.in: build.sh: Add -Wno-missing-field-initializers to CFLAGS zhaogongyi via ltp
2022-12-09 9:50 ` Petr Vorel [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-12-08 13:03 Zhao Gongyi via ltp
2022-12-08 13:24 ` Cyril Hrubis
2022-12-08 14:55 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5ME+qWykgu7PYoV@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=zhaogongyi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox