From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22B25C4332F for ; Mon, 12 Dec 2022 14:34:41 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 7021B3CBE70 for ; Mon, 12 Dec 2022 15:34:40 +0100 (CET) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [IPv6:2001:4b78:1:20::4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id E65C13CA4DD for ; Mon, 12 Dec 2022 15:34:29 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 7CE84100024A for ; Mon, 12 Dec 2022 15:34:29 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C1F1D1F8BD; Mon, 12 Dec 2022 14:34:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1670855668; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9hN0kGhwGJ22ANDMuDrk7DsQfg2jh4eOb0GV5iyhkaI=; b=G3dDVkSBavoYbW0k1CHh6+GKI9KBghVHmqogdp13BIXKF4Uy2dcIvCL8uL2C9a/elabzqu uEDsGpMo2MMX81Q1hZ7ajy62WF3R1Rhdd7Gb5Yv+M7aQmQPRAqLC2U4w83VSH4/eMFScWL 0xtJrK0R8dcPWPUZerYUYlaEhntg4bA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1670855668; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9hN0kGhwGJ22ANDMuDrk7DsQfg2jh4eOb0GV5iyhkaI=; b=n6nuBI35k9dSg0h0ZaMafDwQ17vvzvcb8+4O6KHOOG7fQdh4MY23HgIiAjqhhYKoOOQJMd brRHgKVJVXU5dSCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AE7D7138F3; Mon, 12 Dec 2022 14:34:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /qxyKfQ7l2OmRwAAMHmgww (envelope-from ); Mon, 12 Dec 2022 14:34:28 +0000 Date: Mon, 12 Dec 2022 15:34:15 +0100 From: Cyril Hrubis To: Richard Palethorpe Message-ID: References: <20221212135524.1333-1-rpalethorpe@suse.com> <20221212135524.1333-3-rpalethorpe@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221212135524.1333-3-rpalethorpe@suse.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 3/3] tst_fill_fs: Add alternate access pattern "flat" X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > +enum tst_fill_access_pattern { > + TST_FILL_FLAT_VEC, Not sure if this is a good name, maybe TST_FILL_BLOCKS or TST_FILL_PAGES. > + TST_FILL_RANDOM > +}; Otherwise the whole patchset looks good to me. Reviewed-by: Cyril Hrubis -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp