[LTP] [PATCH] signalfd01.c: put the right round bracket to the right place in tst_resm

[LTP] [PATCH] signalfd01.c: put the right round bracket to the right place in tst_resm

[zijunzhao via ltp]

---
 testcases/kernel/syscalls/signalfd/signalfd01.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/testcases/kernel/syscalls/signalfd/signalfd01.c b/testcases/kernel/syscalls/signalfd/signalfd01.c
index 3df941785..c6a7c3a58 100644
--- a/testcases/kernel/syscalls/signalfd/signalfd01.c
+++ b/testcases/kernel/syscalls/signalfd/signalfd01.c
@@ -249,8 +249,7 @@ void do_test2(int fd, uint32_t sig)
 		goto out;
 	} else {
 		tst_resm(TFAIL, "got unexpected signal: signal=%d : %s",
-			 fdsi.ssi_signo),
-			 strsignal(fdsi.ssi_signo);
+			 fdsi.ssi_signo, strsignal(fdsi.ssi_signo));
 		goto out;
 	}
 
-- 
2.39.0.rc1.256.g54fd8350bd-goog


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] signalfd01.c: put the right round bracket to the right place in tst_resm

[Richard Palethorpe]

Hello,

The patch is perfect, but you need to add your Signed-off-by git trailer
to the commit (or just respond this e-mail with it).

zijunzhao via ltp <ltp@lists.linux.it> writes:

> ---
>  testcases/kernel/syscalls/signalfd/signalfd01.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/signalfd/signalfd01.c b/testcases/kernel/syscalls/signalfd/signalfd01.c
> index 3df941785..c6a7c3a58 100644
> --- a/testcases/kernel/syscalls/signalfd/signalfd01.c
> +++ b/testcases/kernel/syscalls/signalfd/signalfd01.c
> @@ -249,8 +249,7 @@ void do_test2(int fd, uint32_t sig)
>  		goto out;
>  	} else {
>  		tst_resm(TFAIL, "got unexpected signal: signal=%d : %s",
> -			 fdsi.ssi_signo),
> -			 strsignal(fdsi.ssi_signo);
> +			 fdsi.ssi_signo, strsignal(fdsi.ssi_signo));
>  		goto out;
>  	}
>  
> -- 
> 2.39.0.rc1.256.g54fd8350bd-goog


-- 
Thank you,
Richard.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] signalfd01.c: put the right round bracket to the right place in tst_resm

[Petr Vorel]

Hi all,

> Hello,

> The patch is perfect, but you need to add your Signed-off-by git trailer
> to the commit (or just respond this e-mail with it).

I added Zijun's mail and merged. Thanks for the fix!

I dared to slightly modify the commit message and added
Fixes: 3306ad4398 ("m4: clean up ltp-signalfd.m4")

Kind regards,
Petr


> zijunzhao via ltp <ltp@lists.linux.it> writes:

> > ---
> >  testcases/kernel/syscalls/signalfd/signalfd01.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)

> > diff --git a/testcases/kernel/syscalls/signalfd/signalfd01.c b/testcases/kernel/syscalls/signalfd/signalfd01.c
> > index 3df941785..c6a7c3a58 100644
> > --- a/testcases/kernel/syscalls/signalfd/signalfd01.c
> > +++ b/testcases/kernel/syscalls/signalfd/signalfd01.c
> > @@ -249,8 +249,7 @@ void do_test2(int fd, uint32_t sig)
> >  		goto out;
> >  	} else {
> >  		tst_resm(TFAIL, "got unexpected signal: signal=%d : %s",
> > -			 fdsi.ssi_signo),
> > -			 strsignal(fdsi.ssi_signo);
> > +			 fdsi.ssi_signo, strsignal(fdsi.ssi_signo));
> >  		goto out;
> >  	}

> > -- 
> > 2.39.0.rc1.256.g54fd8350bd-goog

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] signalfd01.c: put the right round bracket to the right place in tst_resm

[Petr Vorel]

Hi Zijun,

also, more suggestions:

Add to each patch:
Signed-off-by: Zijun Zhao <zijunzhao@google.com>
You can notice all commits have this.
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
Richie asked you to do this and thus set your pat
https://patchwork.ozlabs.org/project/ltp/patch/20221213003553.3693243-1-zijunzhao@google.com/

Run 'make check-foo' on target you modify (substitute foo for make target).
That checks for common code mistakes and code style.

You can also use this to check your code:
https://github.com/linux-test-project/ltp/wiki/Maintainer-Patch-Review-Checklist

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp