Re: [LTP] [PATCH v3 7/7] doc/c-test-api.txt

[Petr Vorel <pvorel@suse.cz>]

Hi Xu,

> Update min_kver usage. Also inotify04 has removed tst_kvercmp2,
> so remove it.

> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> ---
>  doc/c-test-api.txt | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

> diff --git a/doc/c-test-api.txt b/doc/c-test-api.txt
> index e6d121dce..f4da9ff41 100644
> --- a/doc/c-test-api.txt
> +++ b/doc/c-test-api.txt
> @@ -559,7 +559,8 @@ static struct tst_test test = {
>  Testcases for newly added kernel functionality require kernel newer than a
>  certain version to run. All you need to skip a test on older kernels is to
>  set the '.min_kver' string in the 'struct tst_test' to a minimal required
> -kernel version, e.g. '.min_kver = "2.6.30"'.
> +kernel version, e.g. '.min_kver = "3.10.0"'. For ltp, the oldest supported
> +kernel version is 3.0, so we don't add this check for old kernel ie 2.6.32.
Again, not sure if this should be added.

>  For more complicated operations such as skipping a test for a certain range
>  of kernel versions, following functions could be used:
> @@ -585,8 +586,7 @@ positive means that it's newer.

>  The second function 'tst_kvercmp2()' allows for specifying per-vendor table of
>  kernel versions as vendors typically backport fixes to their kernels and the
> -test may be relevant even if the kernel version does not suggests so. See
> -'testcases/kernel/syscalls/inotify/inotify04.c' for example usage.
> +test may be relevant even if the kernel version does not suggests so.
+1 for this.

Also, I'd wait with this patchset to what brings the discussion of minimal
level.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp