* [LTP] [PATCH v1] Add runltp-ng to upstream @ 2022-12-02 10:30 Andrea Cervesato via ltp 2022-12-02 14:01 ` Petr Vorel 2022-12-05 8:29 ` Richard Palethorpe 0 siblings, 2 replies; 7+ messages in thread From: Andrea Cervesato via ltp @ 2022-12-02 10:30 UTC (permalink / raw) To: ltp runltp-ng is the next generation runner for Linux Testing Project and it will replace the current obsolete runltp script in the next future. Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com> --- .gitmodules | 3 +++ tools/runltp-ng | 1 + 2 files changed, 4 insertions(+) create mode 160000 tools/runltp-ng diff --git a/.gitmodules b/.gitmodules index a3c34af4b..e85fc6279 100644 --- a/.gitmodules +++ b/.gitmodules @@ -4,3 +4,6 @@ [submodule "tools/sparse/sparse-src"] path = tools/sparse/sparse-src url = git://git.kernel.org/pub/scm/devel/sparse/sparse.git +[submodule "tools/runltp-ng"] + path = tools/runltp-ng + url = https://github.com/acerv/runltp-ng diff --git a/tools/runltp-ng b/tools/runltp-ng new file mode 160000 index 000000000..b08471158 --- /dev/null +++ b/tools/runltp-ng @@ -0,0 +1 @@ +Subproject commit b0847115891bd3dddbe920a716342917e7088379 -- 2.35.3 -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH v1] Add runltp-ng to upstream 2022-12-02 10:30 [LTP] [PATCH v1] Add runltp-ng to upstream Andrea Cervesato via ltp @ 2022-12-02 14:01 ` Petr Vorel 2022-12-05 8:23 ` Andrea Cervesato via ltp 2022-12-05 8:29 ` Richard Palethorpe 1 sibling, 1 reply; 7+ messages in thread From: Petr Vorel @ 2022-12-02 14:01 UTC (permalink / raw) To: Andrea Cervesato; +Cc: ltp Hi Andrea, > runltp-ng is the next generation runner for Linux Testing Project and it > will replace the current obsolete runltp script in the next future. > Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com> > --- > .gitmodules | 3 +++ > tools/runltp-ng | 1 + > 2 files changed, 4 insertions(+) > create mode 160000 tools/runltp-ng > diff --git a/.gitmodules b/.gitmodules > index a3c34af4b..e85fc6279 100644 > --- a/.gitmodules > +++ b/.gitmodules > @@ -4,3 +4,6 @@ > [submodule "tools/sparse/sparse-src"] > path = tools/sparse/sparse-src > url = git://git.kernel.org/pub/scm/devel/sparse/sparse.git > +[submodule "tools/runltp-ng"] > + path = tools/runltp-ng > + url = https://github.com/acerv/runltp-ng > diff --git a/tools/runltp-ng b/tools/runltp-ng > new file mode 160000 > index 000000000..b08471158 > --- /dev/null > +++ b/tools/runltp-ng > @@ -0,0 +1 @@ > +Subproject commit b0847115891bd3dddbe920a716342917e7088379 Thank you for this submission! Finally we get close to adding runltp-ng :). I've tested runltp-ng separately last few weeks, next week I'll do more testing of b0847115891bd3dddbe920a716342917e7088379. BTW there are 2 more commits in your master. The integration: What I can see now is that it requires to run "git submodule update --init" by user. Looking at tools/sparse/Makefile. sparse is specific (not needed unless make check is evoked), therefore sparse is not installed if not needed (make in tools/ does not init the submodule). Maybe we could add in tools/Makefile add: git submodule update --init runltp-ng/ That would update only runltp-ng submodule. I suppose there is a reason to deliver the tool separately (without LTP), e.g. separate development or used on systems, which use LTP built into distro package (we already use it in SUSE this way). In that case I'd be for moving the repo to LTP github (https://github.com/linux-test-project/runltp-ng). We could also add it directly to LTP git repository (no submodule), because also for the above case (packaging) is a simple solution using just single repository: there could be two separated packages: ltp and runltp-ng. Otherwise to be part of LTP git repository add code directly to tools/runltp-ng/. Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH v1] Add runltp-ng to upstream 2022-12-02 14:01 ` Petr Vorel @ 2022-12-05 8:23 ` Andrea Cervesato via ltp 2022-12-05 11:03 ` Petr Vorel 0 siblings, 1 reply; 7+ messages in thread From: Andrea Cervesato via ltp @ 2022-12-05 8:23 UTC (permalink / raw) To: Petr Vorel; +Cc: ltp Hi Petr, On 12/2/22 15:01, Petr Vorel wrote: > Hi Andrea, > >> runltp-ng is the next generation runner for Linux Testing Project and it >> will replace the current obsolete runltp script in the next future. >> Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com> >> --- >> .gitmodules | 3 +++ >> tools/runltp-ng | 1 + >> 2 files changed, 4 insertions(+) >> create mode 160000 tools/runltp-ng >> diff --git a/.gitmodules b/.gitmodules >> index a3c34af4b..e85fc6279 100644 >> --- a/.gitmodules >> +++ b/.gitmodules >> @@ -4,3 +4,6 @@ >> [submodule "tools/sparse/sparse-src"] >> path = tools/sparse/sparse-src >> url = git://git.kernel.org/pub/scm/devel/sparse/sparse.git >> +[submodule "tools/runltp-ng"] >> + path = tools/runltp-ng >> + url = https://github.com/acerv/runltp-ng >> diff --git a/tools/runltp-ng b/tools/runltp-ng >> new file mode 160000 >> index 000000000..b08471158 >> --- /dev/null >> +++ b/tools/runltp-ng >> @@ -0,0 +1 @@ >> +Subproject commit b0847115891bd3dddbe920a716342917e7088379 > Thank you for this submission! Finally we get close to adding runltp-ng :). > > I've tested runltp-ng separately last few weeks, next week I'll do more testing > of b0847115891bd3dddbe920a716342917e7088379. BTW there are 2 more commits in > your master. > > The integration: What I can see now is that it requires to run "git submodule > update --init" by user. Looking at tools/sparse/Makefile. sparse is specific > (not needed unless make check is evoked), therefore sparse is not installed if > not needed (make in tools/ does not init the submodule). > > Maybe we could add in tools/Makefile add: > git submodule update --init runltp-ng/ > That would update only runltp-ng submodule. Yes, submodules are not intuitive and it would be better to add code inside the LTP upstream. > I suppose there is a reason to deliver the tool separately (without LTP), > e.g. separate development or used on systems, which use LTP built into distro > package (we already use it in SUSE this way). In that case I'd be for moving the > repo to LTP github (https://github.com/linux-test-project/runltp-ng). > > We could also add it directly to LTP git repository (no submodule), because also > for the above case (packaging) is a simple solution using just single > repository: there could be two separated packages: ltp and runltp-ng. > > Otherwise to be part of LTP git repository > add code directly to tools/runltp-ng/. As far as I know, community wanted runltp-ng to be part of LTP, but at this stage it's probably too early (?). > Kind regards, > Petr Andrea -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH v1] Add runltp-ng to upstream 2022-12-05 8:23 ` Andrea Cervesato via ltp @ 2022-12-05 11:03 ` Petr Vorel 0 siblings, 0 replies; 7+ messages in thread From: Petr Vorel @ 2022-12-05 11:03 UTC (permalink / raw) To: Andrea Cervesato; +Cc: ltp Hi Andrea, > Hi Petr, > On 12/2/22 15:01, Petr Vorel wrote: > > Hi Andrea, > > > runltp-ng is the next generation runner for Linux Testing Project and it > > > will replace the current obsolete runltp script in the next future. > > > Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com> > > > --- > > > .gitmodules | 3 +++ > > > tools/runltp-ng | 1 + > > > 2 files changed, 4 insertions(+) > > > create mode 160000 tools/runltp-ng > > > diff --git a/.gitmodules b/.gitmodules > > > index a3c34af4b..e85fc6279 100644 > > > --- a/.gitmodules > > > +++ b/.gitmodules > > > @@ -4,3 +4,6 @@ > > > [submodule "tools/sparse/sparse-src"] > > > path = tools/sparse/sparse-src > > > url = git://git.kernel.org/pub/scm/devel/sparse/sparse.git > > > +[submodule "tools/runltp-ng"] > > > + path = tools/runltp-ng > > > + url = https://github.com/acerv/runltp-ng > > > diff --git a/tools/runltp-ng b/tools/runltp-ng > > > new file mode 160000 > > > index 000000000..b08471158 > > > --- /dev/null > > > +++ b/tools/runltp-ng > > > @@ -0,0 +1 @@ > > > +Subproject commit b0847115891bd3dddbe920a716342917e7088379 > > Thank you for this submission! Finally we get close to adding runltp-ng :). > > I've tested runltp-ng separately last few weeks, next week I'll do more testing > > of b0847115891bd3dddbe920a716342917e7088379. BTW there are 2 more commits in > > your master. > > The integration: What I can see now is that it requires to run "git submodule > > update --init" by user. Looking at tools/sparse/Makefile. sparse is specific > > (not needed unless make check is evoked), therefore sparse is not installed if > > not needed (make in tools/ does not init the submodule). > > Maybe we could add in tools/Makefile add: > > git submodule update --init runltp-ng/ > > That would update only runltp-ng submodule. > Yes, submodules are not intuitive and it would be better to add code inside > the LTP upstream. > > I suppose there is a reason to deliver the tool separately (without LTP), > > e.g. separate development or used on systems, which use LTP built into distro > > package (we already use it in SUSE this way). In that case I'd be for moving the > > repo to LTP github (https://github.com/linux-test-project/runltp-ng). > > We could also add it directly to LTP git repository (no submodule), because also > > for the above case (packaging) is a simple solution using just single > > repository: there could be two separated packages: ltp and runltp-ng. > > Otherwise to be part of LTP git repository > > add code directly to tools/runltp-ng/. > As far as I know, community wanted runltp-ng to be part of LTP, but at this > stage it's probably too early (?). IMHO it's already mature enough. I'm not sure if there is any important enough runltp feature which it miss, but your code is obviously huge improvement over legacy runltp. Also you fixes various things I reported really quickly, thus I expect you fixes any major issue in reasonable time. Kind regards, Petr > > Kind regards, > > Petr > Andrea -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH v1] Add runltp-ng to upstream 2022-12-02 10:30 [LTP] [PATCH v1] Add runltp-ng to upstream Andrea Cervesato via ltp 2022-12-02 14:01 ` Petr Vorel @ 2022-12-05 8:29 ` Richard Palethorpe 2022-12-12 15:06 ` Richard Palethorpe 2022-12-20 12:27 ` Cyril Hrubis 1 sibling, 2 replies; 7+ messages in thread From: Richard Palethorpe @ 2022-12-05 8:29 UTC (permalink / raw) To: Andrea Cervesato; +Cc: ltp Hello, Andrea Cervesato via ltp <ltp@lists.linux.it> writes: > runltp-ng is the next generation runner for Linux Testing Project and it > will replace the current obsolete runltp script in the next future. > > Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com> > --- > .gitmodules | 3 +++ > tools/runltp-ng | 1 + > 2 files changed, 4 insertions(+) > create mode 160000 tools/runltp-ng > > diff --git a/.gitmodules b/.gitmodules > index a3c34af4b..e85fc6279 100644 > --- a/.gitmodules > +++ b/.gitmodules > @@ -4,3 +4,6 @@ > [submodule "tools/sparse/sparse-src"] > path = tools/sparse/sparse-src > url = git://git.kernel.org/pub/scm/devel/sparse/sparse.git > +[submodule "tools/runltp-ng"] > + path = tools/runltp-ng > + url = https://github.com/acerv/runltp-ng NACK We should move the project into the linux-test-project org first. > diff --git a/tools/runltp-ng b/tools/runltp-ng > new file mode 160000 > index 000000000..b08471158 > --- /dev/null > +++ b/tools/runltp-ng > @@ -0,0 +1 @@ > +Subproject commit b0847115891bd3dddbe920a716342917e7088379 > -- > 2.35.3 -- Thank you, Richard. -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH v1] Add runltp-ng to upstream 2022-12-05 8:29 ` Richard Palethorpe @ 2022-12-12 15:06 ` Richard Palethorpe 2022-12-20 12:27 ` Cyril Hrubis 1 sibling, 0 replies; 7+ messages in thread From: Richard Palethorpe @ 2022-12-12 15:06 UTC (permalink / raw) To: rpalethorpe; +Cc: ltp Hello, Richard Palethorpe <rpalethorpe@suse.de> writes: > Hello, > > Andrea Cervesato via ltp <ltp@lists.linux.it> writes: > >> runltp-ng is the next generation runner for Linux Testing Project and it >> will replace the current obsolete runltp script in the next future. >> >> Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com> >> --- >> .gitmodules | 3 +++ >> tools/runltp-ng | 1 + >> 2 files changed, 4 insertions(+) >> create mode 160000 tools/runltp-ng >> >> diff --git a/.gitmodules b/.gitmodules >> index a3c34af4b..e85fc6279 100644 >> --- a/.gitmodules >> +++ b/.gitmodules >> @@ -4,3 +4,6 @@ >> [submodule "tools/sparse/sparse-src"] >> path = tools/sparse/sparse-src >> url = git://git.kernel.org/pub/scm/devel/sparse/sparse.git >> +[submodule "tools/runltp-ng"] >> + path = tools/runltp-ng >> + url = https://github.com/acerv/runltp-ng > > NACK > > We should move the project into the linux-test-project org first. I am in favor of doing this, but set to "changes requested" in patchwork. > >> diff --git a/tools/runltp-ng b/tools/runltp-ng >> new file mode 160000 >> index 000000000..b08471158 >> --- /dev/null >> +++ b/tools/runltp-ng >> @@ -0,0 +1 @@ >> +Subproject commit b0847115891bd3dddbe920a716342917e7088379 >> -- >> 2.35.3 > > > -- > Thank you, > Richard. -- Thank you, Richard. -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH v1] Add runltp-ng to upstream 2022-12-05 8:29 ` Richard Palethorpe 2022-12-12 15:06 ` Richard Palethorpe @ 2022-12-20 12:27 ` Cyril Hrubis 1 sibling, 0 replies; 7+ messages in thread From: Cyril Hrubis @ 2022-12-20 12:27 UTC (permalink / raw) To: Richard Palethorpe; +Cc: ltp Hi! > NACK > > We should move the project into the linux-test-project org first. Agree. I will create the repository and work with andrea to move the development there. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-12-20 12:26 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-12-02 10:30 [LTP] [PATCH v1] Add runltp-ng to upstream Andrea Cervesato via ltp 2022-12-02 14:01 ` Petr Vorel 2022-12-05 8:23 ` Andrea Cervesato via ltp 2022-12-05 11:03 ` Petr Vorel 2022-12-05 8:29 ` Richard Palethorpe 2022-12-12 15:06 ` Richard Palethorpe 2022-12-20 12:27 ` Cyril Hrubis
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox