From: Petr Vorel <pvorel@suse.cz>
To: Avinesh Kumar <akumar@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] setreuid04.c: Rewrite using new LTP API
Date: Thu, 12 Jan 2023 01:23:20 +0100 [thread overview]
Message-ID: <Y79S+OcmLkTP5UfH@pevik> (raw)
In-Reply-To: <20230111132550.15587-1-akumar@suse.de>
Hi Avinesh,
> -/*
> - * Test that root can change the real and effective uid to an
> - * unpriviledged user.
> +/*\
> + * [Description]
> + *
> + * Verify that root user can change the real and effective uid to an
> + * unprivileged user.
> */
> -struct test_data_t {
> +static struct tcase {
> uid_t *real_uid;
> uid_t *eff_uid;
> + uid_t *exp_real_uid;
> + uid_t *exp_eff_uid;
nit: eff looks really strange. I'd personally use euid and uid or euid and ruid.
But it's really a detail (no need to change this).
Thanks for a nice cleanup.
Reviewed-by: Petr Vorel <akumar@suse.de>
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-01-12 0:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 13:25 [LTP] [PATCH] setreuid04.c: Rewrite using new LTP API Avinesh Kumar
2023-01-12 0:23 ` Petr Vorel [this message]
2023-01-12 10:37 ` Richard Palethorpe
2023-01-16 10:42 ` Richard Palethorpe
2023-01-23 6:48 ` [LTP] [PATCH v2] " Avinesh Kumar
2023-01-23 9:30 ` Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y79S+OcmLkTP5UfH@pevik \
--to=pvorel@suse.cz \
--cc=akumar@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox