From: Petr Vorel <pvorel@suse.cz>
To: Yang Xu <xuyang2018.jy@fujitsu.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/3] shell: Remove old kernel version check below 3.10
Date: Tue, 3 Jan 2023 19:13:06 +0100 [thread overview]
Message-ID: <Y7RwMvU1+QUPbz59@pevik> (raw)
In-Reply-To: <Y7KlxBSIvN3q576G@pevik>
Hi Xu,
...
> This evaluates to FLAG_PREFIX=
> => please remove the variable as it's always empty
> > /bin/echo "$FLAGS_SET" | while read -r FLAG_LINE ; do
> > /bin/echo -n "$FLAG_LINE" \
> > | awk -v prf="$FLAG_PREFIX" -F " |:" \
> change to:
> | awk -v prf= -F " |:" \
FYI I suggested:
> | awk -v prf= -F " |:" \
But you added: prf=-F (no space between =), which broke cleanup.
Fixed in af98698067.
And yes, prf variable is not needed at all, I'll try to find time to cleanup
dynamic_debug01.sh.
Kind regards,
Petr
> NOTE: I'm going to cleanup the test after you merge (/bin/echo + variables).
> With these changes:
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Kind regards,
> Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-01-03 18:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 9:20 [LTP] [PATCH 1/3] shell: Remove old kernel version check below 3.10 Yang Xu
2022-12-27 9:20 ` [LTP] [PATCH 2/3] Remove old kernel version check when using tst_kvercmp under 3.10 Yang Xu
2023-01-02 12:01 ` Petr Vorel
2022-12-27 9:20 ` [LTP] [PATCH 3/3] Remove old kernel version check when using min_kver " Yang Xu
2023-01-02 12:04 ` Petr Vorel
2023-01-02 9:37 ` [LTP] [PATCH 1/3] shell: Remove old kernel version check below 3.10 Petr Vorel
2023-01-03 5:39 ` xuyang2018.jy
2023-01-03 18:13 ` Petr Vorel [this message]
2023-01-04 4:59 ` xuyang2018.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7RwMvU1+QUPbz59@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox