From: Petr Vorel <pvorel@suse.cz>
To: Akihiko Odaki <akihiko.odaki@daynix.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] network/stress/http: Do not use SIGPIPE
Date: Tue, 24 Jan 2023 13:28:45 +0100 [thread overview]
Message-ID: <Y8/O/S/CCh4KCmFV@pevik> (raw)
In-Reply-To: <Y8/AoCIniws6bVjd@pevik>
Hi Akihiko,
> > curl ignores SIGPIPE according to:
> > https://github.com/curl/curl/commit/e2bcd2ab9e5ad894a57756fa660d2a07b69171f4
Although curl really does not kill when testing manually, running:
curl -L -o /tmp/delete.iso http://download.opensuse.org/tumbleweed/iso/openSUSE-Tumbleweed-DVD-x86_64-Current.iso
In another terminal this blocks:
killall -w -s SIGPIPE curl
But when I tested with nginx the original code with -s SIGPIPE) it works:
export HTTP_DOWNLOAD_DIR=/srv/www/htdocs/
PATH="/opt/ltp/testcases/bin:$PATH" http-stress.sh -i3
http-stress 1 TINFO: initialize 'lhost' 'ltp_ns_veth2' interface
http-stress 1 TINFO: add local addr 10.0.0.2/24
http-stress 1 TINFO: add local addr fd00:1:1:1::2/64
http-stress 1 TINFO: initialize 'rhost' 'ltp_ns_veth1' interface
http-stress 1 TINFO: add remote addr 10.0.0.1/24
http-stress 1 TINFO: add remote addr fd00:1:1:1::1/64
http-stress 1 TINFO: Network config (local -- remote):
http-stress 1 TINFO: ltp_ns_veth2 -- ltp_ns_veth1
http-stress 1 TINFO: 10.0.0.2/24 -- 10.0.0.1/24
http-stress 1 TINFO: fd00:1:1:1::2/64 -- fd00:1:1:1::1/64
http-stress 1 TINFO: run over IPv4
http-stress 1 TINFO: http client download test file
http-stress01-rmt 1 TINFO: stat: time=0.933851 size=2147483647 speed=2299599879
http-stress 1 TPASS: Test is finished successfully
http-stress 2 TINFO: clients request data asynchronously 10 sec
http-stress02-rmt 1 TINFO: stat: time=1.464465 size=2147483647 speed=1466394654
http-stress 2 TPASS: Test is finished successfully
pgrep -a curl # nothing
Not sure what am I missing, but I don't see any problem to accept this patch.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-01-24 12:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 4:42 [LTP] [PATCH] network/stress/http: Do not use SIGPIPE Akihiko Odaki
2023-01-24 11:27 ` Petr Vorel
2023-01-24 12:28 ` Petr Vorel [this message]
2023-01-25 21:30 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8/O/S/CCh4KCmFV@pevik \
--to=pvorel@suse.cz \
--cc=akihiko.odaki@daynix.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox