From: Petr Vorel <pvorel@suse.cz>
To: WEI GAO <wegao@suse.com>,
Richard Palethorpe <rpalethorpe@suse.com>,
ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4] Add PATH to tst_rhost_run.sh
Date: Tue, 17 Jan 2023 09:26:13 +0100 [thread overview]
Message-ID: <Y8Zbpfq8xcDZ2uZI@pevik> (raw)
In-Reply-To: <Y8EnKACJtJJ80uw+@pevik>
Hi Wei, all,
I at least once reproduced the problem:
# ./tst_rhost_run.sh
RTNETLINK answers: File exists
tst_rhost_run 1 TBROK: ip li add name ltp_ns_veth1 type veth peer name ltp_ns_veth2 failed
I can't reproduce it now, let's skip it.
Unfortunately there is another problem, which can't be solved with adjusting
PATH for the test, because also remote end would need to have PATH adjusted
With this patch and with your another patch [1]:
# ./tst_rhost_run.sh
...
tst_rhost_run 1 TINFO: tst_rhost_run: cmd: tst_net_iface_prefix -r 10.0.0.1
tst_rhost_run 1 TINFO: NETNS: ns_exec 17258 net,mnt sh -c " tst_net_iface_prefix -r 10.0.0.1 || echo RTERR" 2>&1
./../../../..//testcases/lib/tst_net.sh: line 1027: sh:: command not found
tst_rhost_run 1 TINFO: tst_rhost_run: cmd: tst_net_iface_prefix -r fd00:1:1:1::1
tst_rhost_run 1 TINFO: NETNS: ns_exec 17258 net,mnt sh -c " tst_net_iface_prefix -r fd00:1:1:1::1 || echo RTERR" 2>&1
./../../../..//testcases/lib/tst_net.sh: line 1032: sh:: command not found
...
tst_rhost_run 1 TPASS: tst_rhost_run is working
=> test claims TPASS, but it actually does not work properly (false negative).
Therefore instead of adjusting PATH I want to fix it properly, i.e. moving
to testcases/kernel/containers/share/ (described previously).
Kind regards,
Petr
[1] https://patchwork.ozlabs.org/project/ltp/patch/20230117040132.5245-1-wegao@suse.com/
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-01-17 8:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 11:31 [LTP] [PATCH v3] Add containers/share to PATH when call init_ltp_netspace coolgw
2023-01-10 8:20 ` Petr Vorel
2023-01-11 10:45 ` [LTP] [PATCH v4] Add PATH to tst_rhost_run.sh coolgw
2023-01-11 17:09 ` WEI GAO via ltp
2023-01-11 19:38 ` WEI GAO via ltp
2023-01-11 19:52 ` WEI GAO via ltp
2023-01-13 9:40 ` Petr Vorel
2023-01-16 11:01 ` Cyril Hrubis
2023-01-17 8:26 ` Petr Vorel [this message]
2023-01-17 15:18 ` Wei Gao via ltp
2023-01-26 22:17 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8Zbpfq8xcDZ2uZI@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=rpalethorpe@suse.com \
--cc=wegao@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox