Re: [LTP] [PATCH v1] tst_net.sh: Add more tst_require_cmds check

[Petr Vorel <pvorel@suse.cz>]

Hi Wei,

> More strict check for ns_xxx etc will help avoid following issue:
> https://github.com/linux-test-project/ltp/issues/991

> Signed-off-by: Wei Gao <wegao@suse.com>
> Suggested-by: Petr Vorel <pvorel@suse.cz>
> ---
>  testcases/lib/tst_net.sh | 2 ++
>  1 file changed, 2 insertions(+)

> diff --git a/testcases/lib/tst_net.sh b/testcases/lib/tst_net.sh
> index ceb45c98d..ec915ad74 100644
> --- a/testcases/lib/tst_net.sh
> +++ b/testcases/lib/tst_net.sh
> @@ -205,6 +205,7 @@ tst_rhost_run()
>  	sh_cmd="$pre_cmd $cmd $post_cmd"

>  	if [ -n "${TST_USE_NETNS:-}" ]; then
> +		tst_require_cmds ip ns_create ns_exec ns_ifmove
Why this? none of these commands is used here.

>  		use="NETNS"
>  		rcmd="$LTP_NETNS sh -c"
>  	else
> @@ -1006,6 +1007,7 @@ IPV6_RHOST="${IPV6_RHOST:-fd00:1:1:1::1/64}"
>  # tst_net_iface_prefix -h
>  # tst_net_vars -h
>  if [ -z "$_tst_net_parse_variables" ]; then
> +	tst_require_cmds tst_net_ip_prefix
This is correct.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp