From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BE29C38142 for ; Thu, 19 Jan 2023 18:00:54 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 1C7433CD852 for ; Thu, 19 Jan 2023 19:00:52 +0100 (CET) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [IPv6:2001:4b78:1:20::5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id A44883CC83E for ; Thu, 19 Jan 2023 19:00:41 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id DD6FA60004C for ; Thu, 19 Jan 2023 19:00:40 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2949C218E2; Thu, 19 Jan 2023 18:00:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1674151240; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BftFUOAd0NoQz1UNZ0amgVto3PepOkU3mkvxf+c+HY0=; b=zgurGBBcfgLG8BY25Hctn/OD7dWMHId/g6ZywAS4tNfEBMNGWCFH3KDnBKXNH1f4N7hS7j op2bexzVoIDNkgAvCwBlWcXKvDQDhUc9lqV1g4cLJot0wyD04cG7jsxxl6QJ3WVg9MSuuK k35sbNtqqXpa3hogD3k7QpQnzf9hyrw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1674151240; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BftFUOAd0NoQz1UNZ0amgVto3PepOkU3mkvxf+c+HY0=; b=hpJsThmPYlYUW0PE2uTScb0DhQhXuQm9Y1Ttf0vsqr9hdfZSDS2zzMBbCP1SAKqK9fqvR2 qbUlCkPMpiLWPeBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E25D8134F5; Thu, 19 Jan 2023 18:00:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id pdr1NUeFyWMjFgAAMHmgww (envelope-from ); Thu, 19 Jan 2023 18:00:39 +0000 Date: Thu, 19 Jan 2023 19:00:27 +0100 From: Petr Vorel To: Wei Gao Message-ID: References: <20230119132536.23209-1-wegao@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230119132536.23209-1-wegao@suse.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v1] Move semaphore/ tests to semop/ X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Wei, > There is no point in having two different directories with semop() > testcaes so it would make sense to move these two tests into the > syscalls/ipc/semop/ directory as semop04 and semop05. > So we move ipc/semaphore/ tests to syscalls/ipc/semop/. > Also update runtest files accordingly. testcases/kernel/ipc/semaphore/Makefile links with libpthread.so.0: LDLIBS += -lpthread Although it looks like only sem02.c uses pthread functions. https://man7.org/linux/man-pages/man7/pthreads.7.html testcases/kernel/syscalls/ipc/semop/Makefile links with ltp library libltpnewipc.a: LTPLDLIBS = -lltpnewipc which uses /proc/sysvipc/ https://man7.org/linux/man-pages/man7/sysvipc.7.html I'm not sure if it's good idea to mix both @Cyril any input? > +++ b/testcases/kernel/syscalls/ipc/semop/Makefile > @@ -8,5 +8,6 @@ LTPLIBS = ltpnewipc > include $(top_srcdir)/include/mk/testcases.mk > LTPLDLIBS = -lltpnewipc > +LDLIBS += -lpthread If it's ok to merge them into single directory, it'd be better to specify used libraries for files which need them. e.g.: semop01: LTPLDLIBS = -lltpnewipc semop02: LTPLDLIBS = -lltpnewipc semop03: LTPLDLIBS = -lltpnewipc semop05: LDLIBS += -lpthread Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp