Re: [LTP] [PATCH 1/2] hugemmap15: Compile with -O

Petr Vorel
2023-01-27T08:28:57Z

Hi all,

> >> Though It already got merged, please note this,
> > FYI this has not been merged (only the second patch "hugemmap15: Use
> > TST_TEST_TCONF() for unsupported archs", which was needed to fix compilations).

> Ok.
And don't worry, this will not be merged before release,
which is going to happen hopefully today (or on Monday).

> >> IIRC, I specifically turned off optimization for hugemmap15
> >> because of clang compiler issue, it behaves weirdly with clang
> >> without -O0 and test fails on the system.

> > Isn't -O the same as -O0 ?
> I think -O is -O1.
Yes, -O Equivalent to -O1 [1].

> I tested with clang with -O, it fails. So yeah it is not turning off
> relevant optimization.

Yes, you're right. It worked for me, but after full cleanup it really failed
with -O or -O1 (at least on x86_64 on clang 15.0.7).

@Cyril: I wonder why we need
1) -D_FORTIFY_SOURCE=2 for all (in CPPFLAGS), defined in m4/ltp-fortify_source.m4,
this will warn, when we need to disable optimisation for some test?
-D_FORTIFY_SOURCE=0 obviously warn for redefinition.
It was added in 2013 (4b3007a8e1), not sure which glibc version required it, but
maybe time to drop it? (after release of course)
2) to use CPPFLAGS and CFLAGS together?

Kind regards,
Petr

[1] https://clang.llvm.org/docs/CommandGuide/clang.html