Linux Test Project
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/msync: Assgin value for page_sz
Date: Tue, 26 Jan 2021 09:26:30 +0100	[thread overview]
Message-ID: <YA/SNjjU5ob6S4KR@pevik> (raw)
In-Reply-To: <CAEemH2cHD43cw0nRNHDYF3R5sr0PQYAhtPHz+oxbDMSqsyEJ+g@mail.gmail.com>

Hi Xu, Li,

> On Tue, Jan 26, 2021 at 9:42 AM Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> wrote:

> > Since the previous patch, it removes useless getpagesize()
> > check because this function never fail. But it also remove
> > the page_size assignment and it lead case fail as below:

> > msync02     1  TBROK  :  msync02.c:133: mmap failed: errno=EINVAL(22):
> > Invalid argument
> > msync02     2  TBROK  :  msync02.c:133: Remaining cases broken
> > msync02     3  TBROK  :  msync02.c:147: munmap failed: errno=EINVAL(22):
> > Invalid argument

> > Fix this and also fix compiler warning by using size_t data type instead
> > of int.


> Pushed, thanks for the fix.
I'm sorry for a regression and thanks for fixing it.

Kind regards,
Petr

      reply	other threads:[~2021-01-26  8:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26  1:41 [LTP] [PATCH] syscalls/msync: Assgin value for page_sz Yang Xu
2021-01-26  7:02 ` Li Wang
2021-01-26  8:26   ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YA/SNjjU5ob6S4KR@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox