From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH V2 0/3] add rtctime libs and rtc02 case
Date: Mon, 25 Jan 2021 11:48:34 +0100 [thread overview]
Message-ID: <YA6iAkYyomg1WkTS@yuki.lan> (raw)
In-Reply-To: <20210111083711.1715851-1-gengcixi@gmail.com>
Hi!
I've fixed a few problems in the patchset and pushed, thanks.
Mostly minor changes such as constifying the rtc_dev string pointer and
a few typo fixes, but also added missing function prototypes to the rtc_time.h
> 1. keep tst_rtc_gettime and tst_rtc_settime no change to "static
> inline"(V1) for some compile warning and referring to
> tst_clock_gettime in tst_clocks.h
This was due to missing include to sys/ioctl.h which declares the _IO()
macro used to define RTC_RD_TIME and RTC_SET_TIME
> 2. in .h, use identifiers format "/* XXX /*" rather than "// XXX"
> for kernel checkpatch "WARNING" as follow:
I guess that we may as well switch to the kernel format then.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2021-01-25 10:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 8:37 [LTP] [PATCH V2 0/3] add rtctime libs and rtc02 case gengcixi
2021-01-11 8:37 ` [LTP] [PATCH V2 1/3] lib: add tst_rtctime* for rtc test gengcixi
2021-01-11 8:37 ` [LTP] [PATCH V2 2/3] lib: implement rtc_clock_save and rtc_clock_restore function gengcixi
2021-01-11 8:37 ` [LTP] [PATCH V2 3/3] device-drivers/rtc: add verify rtc set time case gengcixi
2021-01-25 10:48 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YA6iAkYyomg1WkTS@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox