From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] fs/lftest: Convert to new library
Date: Tue, 19 Jan 2021 12:01:35 +0100 [thread overview]
Message-ID: <YAa8D8iQwaQr2tAm@pevik> (raw)
In-Reply-To: <20201215092534.757347-1-lkml@jv-coder.de>
Hi Joerg,
> Additonal changes:
> - Use temp directory instead of working dir
> - 100 buffers is teh default now and can be changed using -n
> - Removed some useless output (nseek, nwrite was always bufnum)
Reviewed-by: Petr Vorel <pvorel@suse.cz>
LGTM, going to merge it after Jan 2021 release.
Below are 2 tiny details I'll fix during merge.
...
> +++ b/runtest/fs
> @@ -58,7 +58,7 @@ ftest06 ftest06
> ftest07 ftest07
> ftest08 ftest08
> -lftest01 lftest 100
> +lftest01 lftest
Not sure if anybody uses runtest/fs_readonly, but we still haven't removed it.
Thus it must be also updated:
-test_robind54 test_robind.sh -c "lftest 80"
+test_robind54 test_robind.sh -c "lftest"
...
> +++ b/testcases/kernel/fs/lftest/lftest.c
...
> + if (str_bufnum) {
> + if (tst_parse_int(str_bufnum ,&bufnum, 0, INT_MAX)) {
nit: formatting:
if (tst_parse_int(str_bufnum, &bufnum, 0, INT_MAX)) {
> + tst_brk(TBROK, "Invalid buffer count '%s'", str_bufnum);
> + }
Kind regards,
Petr
next prev parent reply other threads:[~2021-01-19 11:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 9:25 [LTP] [PATCH] fs/lftest: Convert to new library Joerg Vehlow
2021-01-19 11:01 ` Petr Vorel [this message]
2021-01-20 5:30 ` Joerg Vehlow
2021-01-21 14:44 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAa8D8iQwaQr2tAm@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox