From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/2] lib: Fix kernel module detection on BusyBox
Date: Wed, 20 Jan 2021 13:11:35 +0100 [thread overview]
Message-ID: <YAgd95cI0527bXa8@pevik> (raw)
In-Reply-To: <a60fb78b-4441-4f17-d0c2-db50292cfde6@jv-coder.de>
Hi J?rg,
> Hi,
> On 1/19/2021 8:41 AM, Petr Vorel wrote:
> > Hi,
> > > diff --git a/lib/tst_kernel.c b/lib/tst_kernel.c
> > ...
> > > -int tst_check_driver(const char *name)
> > > +#ifndef __ANDROID__
> > > +# define MODULES_DIR "/lib/modules"
> > > +#else
> > > +# define MODULES_DIR "/system/lib/modules"
> > > +#endif
> > OK, MODULES_DIR is not needed now as I kept Android skipped (unless somebody
> > contributes code or share algorithm for Android).
> I don't get this comment. MODULES_DIR is used in both code paths in
> tst_search_driver.
Please have look at v3, where I removed MODULES_DIR
https://patchwork.ozlabs.org/project/ltp/patch/20210119160316.4776-2-pvorel@suse.cz/
> But you don't call it from tst_check_driver only if it is not android.
> If tst_search_driver is supposed to be a new public interface, it should be
> added to the header,
> otherwise it should be marked static.
+1 I'll make it static.
Kind regards,
Petr
> J?rg
next prev parent reply other threads:[~2021-01-20 12:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 16:13 [LTP] [PATCH v2 1/2] lib: Fix kernel module detection on BusyBox Petr Vorel
2021-01-19 7:41 ` Petr Vorel
2021-01-20 11:22 ` Joerg Vehlow
2021-01-20 12:11 ` Petr Vorel [this message]
2021-01-19 13:31 ` Cyril Hrubis
2021-01-19 13:39 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAgd95cI0527bXa8@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox