[LTP] [PATCH v2 2/4] Add safe functions for io_uring to LTP library

Petr Vorel
2021-02-05T17:06:08Z

Hi Martin,

> >> +++ b/lib/tst_safe_io_uring.c
> > ...
> >> + uring->sqr_base = safe_mmap(file, lineno, NULL, uring->sqr_mapsize,
> >> + PROT_READ | PROT_WRITE, MAP_SHARED | MAP_POPULATE, uring->fd,
> >> + IORING_OFF_SQ_RING);
> >> +
> >> + if (uring->sqr_base == MAP_FAILED)
> >> + return -1;
> > IMHO this is not needed, safe_mmap() breaks on rval == MAP_FAILED.

> Except when called in cleanup() where it prints a warning and returns as
> usual. That's why safe_io_uring_init() returns int instead of void in
> the first place.

> I don't expect that safe_io_uring_init() will be used in cleanup() very
> often but I've made all the other SAFE_*() functions cleanup()-safe and
> I want to stick with that here as well.

Good point, makes sense. Thanks for an explanation.

Kind regards,
Petr