public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/3] lib/tst_net.sh: print all netstress results in tst_netload()
Date: Fri, 5 Feb 2021 07:59:53 +0100	[thread overview]
Message-ID: <YBzs6V68xkamzfcx@pevik> (raw)
In-Reply-To: <20210202133454.59224-2-alexey.kodanev@oracle.com>

Hi Alexey,

Reviewed-by: Petr Vorel <pvorel@suse.cz>

...
> -	res=$((res / $passed))
> -	echo "$res" > $rfile
> +	local mean res_sum
r should be also local.
> +	for r in $results; do
> +		res_sum="$((res_sum + r))"
> +	done
> +	mean=$((res_sum / passed))
> +	echo "$mean" > $rfile

> -	tst_res_ TPASS "netstress passed, mean time '$res' ms"
> +	tst_res_ TPASS "netstress passed, mean time $mean ms, data:$results"

Kind regards,
Petr

  reply	other threads:[~2021-02-05  6:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-02 13:34 [LTP] [PATCH 0/3] lib/tst_net.sh: calc median instead of mean in tst_netload() Alexey Kodanev
2021-02-02 13:34 ` [LTP] [PATCH 1/3] lib/tst_net.sh: print all netstress results " Alexey Kodanev
2021-02-05  6:59   ` Petr Vorel [this message]
2021-02-02 13:34 ` [LTP] [PATCH 2/3] lib: add tst_get_median helper binary for use in script tests Alexey Kodanev
2021-02-05 10:15   ` Petr Vorel
2021-02-02 13:34 ` [LTP] [PATCH 3/3] lib/tst_net.sh: calc median instead of mean in tst_netload() Alexey Kodanev
2021-02-05 10:17   ` Petr Vorel
2021-02-05 10:21 ` [LTP] [PATCH 0/3] " Petr Vorel
2021-02-08 15:24   ` Alexey Kodanev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YBzs6V68xkamzfcx@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox