From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] configure: Improve error message on missing pkg-config
Date: Thu, 18 Feb 2021 11:16:22 +0100 [thread overview]
Message-ID: <YC4+dlPsqvmYaAks@yuki.lan> (raw)
In-Reply-To: <YCugPYQxkf61gxiK@pevik>
Hi!
> > +m4_ifndef([PKG_PREREQ],
> > + [m4_fatal([must install pkg-config or pkgconfig and pkg.m4 macro (usual dependency)])])
> Maybe mention also INSTALL file (feedback from
> https://github.com/linux-test-project/ltp/issues/787):
>
> [m4_fatal([must install pkg-config or pkgconfig and pkg.m4 macro (usual dependency), see INSTALL for all dependencies])])
Maybe just shorten it to "..., see INSTALL"
Other than that no complaints, anything that prints reasonable message
is much better than the cryptic error we produce without this patch.
So Acked-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2021-02-18 10:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 11:04 [LTP] [PATCH 1/1] configure: Improve error message on missing pkg-config Petr Vorel
2021-02-16 10:36 ` Petr Vorel
2021-02-18 10:16 ` Cyril Hrubis [this message]
2021-02-18 13:55 ` Petr Vorel
2021-02-18 14:36 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YC4+dlPsqvmYaAks@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox