From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] netns_helper: Make iproute version check work correctly
Date: Tue, 9 Feb 2021 16:55:54 +0100 [thread overview]
Message-ID: <YCKwiqsfPi47PT/b@yuki.lan> (raw)
In-Reply-To: <YCKim8Pvg+ZTrHXI@rei>
Hi!
> > static int dummy(void *arg)
> > diff --git a/testcases/kernel/containers/netns/netns_helper.sh b/testcases/kernel/containers/netns/netns_helper.sh
> > index a5b77a0..bec43ac 100755
> > --- a/testcases/kernel/containers/netns/netns_helper.sh
> > +++ b/testcases/kernel/containers/netns/netns_helper.sh
> > @@ -50,6 +50,15 @@ tst_check_iproute()
> > local cur_ipver="$(ip -V)"
> > local spe_ipver="$1"
> >
> > + echo $cur_ipver | grep "ip utility, iproute2-ss" > /dev/null
> > + ret1=$?
> > + echo $cur_ipver | grep "ip utility, iproute2-" > /dev/null
> > + ret2=$?
> > +
> > + if [ $ret1 -ne 0 -a $ret2 -eq 0 ]; then
> > + return
> > + fi
>
> How is this supposed to fix the problem?
>
> This just skips the test if we haven't found one of the strings in the
^
I mean version check, the test iself continues
If nothing else this should TBROK.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2021-02-09 15:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 8:14 [LTP] [PATCH] netns_helper: Make iproute version check work correctly Feiyu Zhu
2021-02-09 14:56 ` Cyril Hrubis
2021-02-09 15:55 ` Cyril Hrubis [this message]
2021-02-10 8:07 ` Petr Vorel
2021-02-10 13:38 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCKwiqsfPi47PT/b@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox