public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/4] net/multicast: Create mcast_setup_normal()
Date: Wed, 10 Feb 2021 14:08:56 +0100	[thread overview]
Message-ID: <YCPa6EI4zyGzDEz1@pevik> (raw)
In-Reply-To: <5f9aecc2-096b-6b24-bdfa-f9d361fcbac7@oracle.com>

Hi Alexey,

> > +++ testcases/network/stress/multicast/packet-flood/mcast-pktfld02.sh
> > @@ -12,13 +12,13 @@ TST_NEEDS_ROOT=1
> >  TST_SETUP="mcast_setup_normal"
> >  . mcast-lib.sh

> > -MCAST_LCMD="ns-mcast_receiver"
> > -MCAST_RCMD="ns-udpsender"
> > -
> >  do_test()
> >  {
> >  	tst_res TINFO "joining $MCASTNUM_NORMAL IPv${TST_IPVER} multicast groups on separate sockets, then receiving a large number of UDP packets at each socket in $NS_DURATION seconds"

> > +	MCAST_LCMD="ns-mcast_receiver"
> > +	MCAST_RCMD="ns-udpsender"
> > +

> Hi Petr,

> Perhaps it would be better to move this to another wrapper
> in the lib along with mcast_setup_normal()?

Good idea, thanks!

> mcast_setup_normal_udp()
> {
>         mcast_setup_normal
> 	MCAST_LCMD="ns-mcast_receiver"
> 	MCAST_RCMD="ns-udpsender"
> }

Kind regards,
Petr

  reply	other threads:[~2021-02-10 13:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05 15:10 [LTP] [PATCH 1/4] net/multicast: Create mcast_setup_normal() Petr Vorel
2021-02-05 15:10 ` [LTP] [PATCH 2/4] net/multicast: Move API variables from setup to tests Petr Vorel
2021-02-05 15:10 ` [LTP] [PATCH 3/4] net/multicast: Remove duplicity Petr Vorel
2021-02-05 15:10 ` [LTP] [PATCH 4/4] net/multicast: Use SPDX-License-Identifier Petr Vorel
2021-02-06 19:14 ` [LTP] [PATCH 1/4] net/multicast: Create mcast_setup_normal() Petr Vorel
2021-02-10 11:56   ` Alexey Kodanev
2021-02-10 13:08     ` Petr Vorel [this message]
2021-02-12 19:26     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YCPa6EI4zyGzDEz1@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox