public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] splice02: Generate input in C
Date: Tue, 9 Mar 2021 09:15:03 +0100	[thread overview]
Message-ID: <YEcuh38X83GX1RPL@yuki.lan> (raw)
In-Reply-To: <YEcPvIckAEbmMBi9@pevik>

Hi!
> > That would not work, the pipe is supposed to be in the runtest file.
> Do you want to test that runtest is working with pipe?

Yes, that was the original idea behind adding the splice test there.

> I considered anything but shell script with getopt parameters a bit strange and
> thought it'd be removed in new shell runner. But obviously you want to keep it.

We will have to keep the functionality for the time being.

> But in case of failure script don't detect it. e.g.:
> 
> echo "SUCCESS" | cat /asdf
> cat: /asdf: No such file or directory
> 
> => there is no TFAIL/TBROK/TCONF. Not sure if all users check exit status (which
> they should now, because that is the only common thing so far).

Well yes, I guess that we can do something as:

echo "SUCCESS" | grep -q "SUCCESS"

Which at least returns 1 if the grep fails.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2021-03-09  8:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-08 15:44 [LTP] [PATCH] splice02: Generate input in C Petr Vorel
2021-03-08 16:40 ` Cyril Hrubis
2021-03-08 18:08   ` Petr Vorel
2021-03-08 18:29     ` Cyril Hrubis
2021-03-09  6:03       ` Petr Vorel
2021-03-09  8:15         ` Cyril Hrubis [this message]
2021-03-09  9:22           ` Petr Vorel
2021-03-09 12:26             ` Cyril Hrubis
2021-03-09 14:14               ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YEcuh38X83GX1RPL@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox