From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 4/4] doc: Update docs on filesystem detection
Date: Thu, 11 Mar 2021 12:34:20 +0100 [thread overview]
Message-ID: <YEoAPF+1RUw2/wDD@pevik> (raw)
In-Reply-To: <20210311105509.2701-5-chrubis@suse.cz>
Hi Cyril,
> - /*
> - * Unsupported on NFS, TMPFS and RAMFS
> - */
> - long type;
> +[source,c]
> +-------------------------------------------------------------------------------
> +#include "tst_test.h"
> +
> +static void run(void)
> +{
> + ...
> switch ((type = tst_fs_type("."))) {
> case TST_NFS_MAGIC:
> case TST_TMPFS_MAGIC:
> case TST_RAMFS_MAGIC:
> - tst_brk(TCONF, "Test not supported on %s filesystem",
> + tst_brk(TCONF, "Subtest not supported on %s",
> tst_fs_type_name(type));
> + return;
> break;
> }
> +
> + ...
> +}
> -------------------------------------------------------------------------------
> +If test needs to adjust expectations based on filesystem type it's also
> +possible to detect filesystem type at the runtime. This is preferably used
> +when only subset of the test is not applicable for a given filesystem.
Should be this paragraph above the previous code example and not below? As the
example illustrates the case of this paragraph.
Apart from that whole patchset LGTM, nice changes.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
next prev parent reply other threads:[~2021-03-11 11:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 10:55 [LTP] [PATCH v2 0/4] Add proper filesystem skiplist Cyril Hrubis
2021-03-11 10:55 ` [LTP] [PATCH v2 1/4] lib: " Cyril Hrubis
2021-03-12 11:06 ` [LTP] [PATCH v3] " Martin Doucha
2021-03-12 14:05 ` Cyril Hrubis
2021-03-12 17:00 ` Martin Doucha
2021-03-11 10:55 ` [LTP] [PATCH v2 2/4] lib: tst_fs_type change fs names to lowercase Cyril Hrubis
2021-03-11 10:55 ` [LTP] [PATCH v2 3/4] lib: Apply the skip_filesystems to rest of test as well Cyril Hrubis
2021-03-11 10:55 ` [LTP] [PATCH v2 4/4] doc: Update docs on filesystem detection Cyril Hrubis
2021-03-11 11:34 ` Petr Vorel [this message]
2021-03-11 12:46 ` [LTP] [PATCH v2 0/4] Add proper filesystem skiplist Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEoAPF+1RUw2/wDD@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox