public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] Add FS quota availability check functions
Date: Fri, 12 Mar 2021 11:28:41 +0100	[thread overview]
Message-ID: <YEtCWbqdGq5Yc99s@pevik> (raw)
In-Reply-To: <20210309171104.30821-1-mdoucha@suse.cz>

Hi Martin,

> +int tst_check_quota_support(const char *device, int format,
> +	const char *quotafile)
> +{
> +	TEST(quotactl(QCMD(Q_QUOTAON, USRQUOTA), device, format, quotafile));
Actually, there is a warning:
tst_supported_fs_types.c: In function ?tst_check_quota_support?:
tst_supported_fs_types.c:117:59: warning: passing argument 4 of ?quotactl? discards ?const? qualifier from pointer target type [-Wdiscarded-qualifiers]
  117 |  TEST(quotactl(QCMD(Q_QUOTAON, USRQUOTA), device, format, quotafile));

Would you prefer to cast to char *, or just change function parameter to char *?

Kind regards,
Petr

> +
> +	/* Not supported */
> +	if (TST_RET == -1 && TST_ERR == ESRCH)
> +		return 0;
> +
> +	/* Broken */
> +	if (TST_RET)
> +		return -1;
> +
> +	quotactl(QCMD(Q_QUOTAOFF, USRQUOTA), device, 0, 0);
> +	return 1;
> +}

  parent reply	other threads:[~2021-03-12 10:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09 17:11 [LTP] [PATCH 1/2] Add FS quota availability check functions Martin Doucha
2021-03-09 17:11 ` [LTP] [PATCH 2/2] syscalls/quotactl: Skip tests if FS quota is not supported Martin Doucha
2021-03-12 10:33   ` Petr Vorel
2021-03-12 10:39   ` Petr Vorel
2021-03-12 10:21 ` [LTP] [PATCH 1/2] Add FS quota availability check functions Petr Vorel
2021-03-12 10:28 ` Petr Vorel [this message]
2021-03-12 17:15   ` Martin Doucha
2021-03-12 17:37     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YEtCWbqdGq5Yc99s@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox