From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Vorel Date: Fri, 12 Mar 2021 18:37:50 +0100 Subject: [LTP] [PATCH 1/2] Add FS quota availability check functions In-Reply-To: References: <20210309171104.30821-1-mdoucha@suse.cz> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi Martin, > >> + TEST(quotactl(QCMD(Q_QUOTAON, USRQUOTA), device, format, quotafile)); > > Actually, there is a warning: > > tst_supported_fs_types.c: In function ?tst_check_quota_support?: > > tst_supported_fs_types.c:117:59: warning: passing argument 4 of ?quotactl? discards ?const? qualifier from pointer target type [-Wdiscarded-qualifiers] > > 117 | TEST(quotactl(QCMD(Q_QUOTAON, USRQUOTA), device, format, quotafile)); > > Would you prefer to cast to char *, or just change function parameter to char *? > Thanks for catching this. Passing string literals to the function > directly is technically wrong so I'll drop the const and fix the tests > to allocate a buffer for quotafile paths. I'll resubmit on Monday. Thanks a lot! Kind regards, Petr