From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] syscalls/getppid01: Convert to the new API
Date: Tue, 16 Mar 2021 17:43:54 +0100 [thread overview]
Message-ID: <YFDgSgFNMH8fUwNr@pevik> (raw)
In-Reply-To: <20210304021304.1126635-1-ruansy.fnst@fujitsu.com>
Hi Ruan,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
You extended test: checking PID range, good.
> +/*\
> + * [DESCRIPTION]
> + *
> + * Test whether parent process id that getpid() returns is out of range.
> +\*/
nit: only */
...
> + SAFE_FILE_SCANF("/proc/sys/kernel/pid_max", "%d\n", &pid_max);
> + if (ppid > pid_max)
> + tst_res(TFAIL, "getppid() returned %d, out of range!", ppid);
> + else
> + tst_res(TPASS, "getppid() returned %d", ppid);
> }
Kind regards,
Petr
next prev parent reply other threads:[~2021-03-16 16:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 2:13 [LTP] [PATCH 1/2] syscalls/getppid01: Convert to the new API Shiyang Ruan
2021-03-04 2:13 ` [LTP] [PATCH 2/2] syscalls/getppid02: " Shiyang Ruan
2021-03-16 16:37 ` Petr Vorel
2021-03-16 16:40 ` Petr Vorel
2021-03-17 9:01 ` ruansy.fnst
2021-03-17 9:19 ` Petr Vorel
2021-04-23 14:43 ` Cyril Hrubis
2021-03-16 16:43 ` Petr Vorel [this message]
2021-04-23 14:39 ` [LTP] [PATCH 1/2] syscalls/getppid01: " Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFDgSgFNMH8fUwNr@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox