public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] cleanup: Unify the annotation style and remove Redundant code
Date: Wed, 17 Mar 2021 11:56:06 +0100	[thread overview]
Message-ID: <YFHgRpFpN9V0Mpxf@pevik> (raw)
In-Reply-To: <YFHLCI7WPPQ/zW+X@pevik>

Hi Gongyi,

> > Change 'Description' to 'DESCRIPTION' and change 'Algorithm' to
> > 'ALGORITHM' and remove Redundant tst_reap_children since tst_reap_children
> > has been called in the test skeleton.

> Actually the preferred form is Description (only first letter capitalized),
> see f5a269142 ("docparse: Unify Description and Algorithm titles").
> (Better would be to also update it in tests, which I haven't done).

> Thus I'd be for merging only removing tst_reap_children() (good catch).

Merged just part removing tst_reap_children().
Thanks!

Kind regards,
Petr

  reply	other threads:[~2021-03-17 10:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-17  4:03 [LTP] [PATCH] cleanup: Unify the annotation style and remove Redundant code Zhao Gongyi
2021-03-17  9:25 ` Petr Vorel
2021-03-17 10:56   ` Petr Vorel [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-03-17 10:04 zhaogongyi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YFHgRpFpN9V0Mpxf@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox