From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] 回复: [PATCH v2] cleanup: Unify the annotation style and remove Redundant code
Date: Wed, 17 Mar 2021 12:34:34 +0100 [thread overview]
Message-ID: <YFHpSspnD52A8N0P@pevik> (raw)
In-Reply-To: <OS0PR01MB6371A1E607BDFBC2421E6788836A9@OS0PR01MB6371.jpnprd01.prod.outlook.com>
Hi all,
> > Hi Gongyi,
> > > Change 'DESCRIPTION' to 'Description' and change 'ALGORITHM' to
> > > 'Algorithm', and remove Redundant tst_reap_children since
> > > tst_reap_children has been called in the test skeleton.
> > Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Hi Petr,
> If we want to unify the format of 'Description' and 'Algorithm' in test, it seems redundant to do the conversion in testinfo.pl, right?
> Can we use either of them(not both of them) because it is unnecessary to do the same thing twice.
I'd keep both: this is for cleanup of old approach, conversion in testinfo.pl in
case there is inconsistency in the future.
But not a strong opinion about it, it's not that important.
Kind regards,
Petr
next prev parent reply other threads:[~2021-03-17 11:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 10:01 [LTP] [PATCH v2] cleanup: Unify the annotation style and remove Redundant code Zhao Gongyi
2021-03-17 10:57 ` Petr Vorel
2021-03-17 11:12 ` [LTP] 回复: " yangx.jy
2021-03-17 11:34 ` Petr Vorel [this message]
2021-03-17 12:09 ` [LTP] ??????: " Cyril Hrubis
2021-03-17 12:13 ` Petr Vorel
2021-03-17 12:32 ` Xiao Yang
2021-03-17 13:02 ` Petr Vorel
2021-03-17 12:09 ` [LTP] 回复: " Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFHpSspnD52A8N0P@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox