From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/semctl09: Skip libc test if SEM_STAT_ANY not defined
Date: Thu, 18 Mar 2021 19:30:16 +0100 [thread overview]
Message-ID: <YFOcOJP4innlbIk4@pevik> (raw)
In-Reply-To: <20210318162409.9871-1-mdoucha@suse.cz>
Hi Martin,
> The libc test variant should run only if system headers define SEM_STAT_ANY.
> Skip it if we're falling back to the LAPI definition.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Thanks!
...
> +#if !HAVE_DECL_SEM_STAT_ANY
nit: I'd prefer
#ifndef HAVE_DECL_SEM_STAT_ANY
> + if (tst_variant == 1)
> + tst_brk(TCONF, "libc does not support semctl(SEM_STAT_ANY)");
> +#endif
Although I understand why you want to quit only tests with root
(only these fail), it's a bit confusing to test with user nobody
and then quit the same testing with root.
Kind regards,
Petr
next prev parent reply other threads:[~2021-03-18 18:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 16:24 [LTP] [PATCH] syscalls/semctl09: Skip libc test if SEM_STAT_ANY not defined Martin Doucha
2021-03-18 18:30 ` Petr Vorel [this message]
2021-03-19 2:56 ` Yang Xu
2021-03-19 8:29 ` Petr Vorel
2021-03-19 8:44 ` xuyang2018.jy
2021-03-19 9:49 ` Martin Doucha
2021-03-19 11:22 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFOcOJP4innlbIk4@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox