From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 2/2] doc: Add Maintainer Patch Review Checklist
Date: Fri, 19 Mar 2021 10:04:26 +0100 [thread overview]
Message-ID: <YFRpGgpEKp+1c9uZ@pevik> (raw)
In-Reply-To: <CAEemH2dRU-3Q-qjE+t_O6Zh8MKDg4C+1vPAnUR+Js9_fHvFykA@mail.gmail.com>
> Li Wang <liwang@redhat.com> wrote:
> > +Commit messages should have
> >> +
> >> +* Author's `Signed-off-by` tag
> >> +* Committer's `Reviewed-by` or `Signed-off-by` tag
> > Or adding `Acked-by:` also acceptable?
> > I'm not sure what's the difference between Acked-by and Reviewed-by,
> > but personally feel the Acked-by has more confidence in the reviewing.
> > In my mind,
> > `Acked-by` means:
> > code review OK, compiled OK, executed OK, has confidence it OK for all
> > arches
> > `Reviewed-by` means:
> > code review OK, compiled and executed OK just locally or optional, still room
> > for improvement/discussion
> Plz ignore my rough understanding, I find a precise description at kernel
> process/submitting-patches.rst.
> https://github.com/torvalds/linux/blob/master/Documentation/process/submitting-patches.rst#when-to-use-acked-by-cc-and-co-developed-by
But you were right, I omit "tags". Maybe this?
- Check also mailing lists for other reviewers / testers
+ Check also mailing lists for other reviewers / testers tags, notes and failure reports
Kind regards,
Petr
next prev parent reply other threads:[~2021-03-19 9:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 18:16 [LTP] [PATCH v2 0/2] doc: Add Maintainer Patch Review Checklist Petr Vorel
2021-03-18 18:16 ` [LTP] [PATCH v2 1/2] doc: Document test tags Petr Vorel
2021-03-19 4:17 ` Li Wang
2021-03-19 9:01 ` Petr Vorel
2021-03-19 9:30 ` Cyril Hrubis
2021-03-18 18:16 ` [LTP] [PATCH v2 2/2] doc: Add Maintainer Patch Review Checklist Petr Vorel
2021-03-19 4:34 ` Li Wang
2021-03-19 4:56 ` Li Wang
2021-03-19 9:04 ` Petr Vorel [this message]
2021-03-19 9:23 ` Cyril Hrubis
2021-03-19 10:05 ` Petr Vorel
2021-03-19 9:25 ` xuyang2018.jy
2021-03-19 9:31 ` Cyril Hrubis
2021-03-19 11:09 ` Petr Vorel
2021-03-19 12:13 ` Cyril Hrubis
2021-03-19 12:43 ` Li Wang
2021-04-01 10:30 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFRpGgpEKp+1c9uZ@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox