From: Heiko Carstens <hca@linux.ibm.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 0/3] s390 vdso fixes
Date: Thu, 25 Mar 2021 13:33:05 +0100 [thread overview]
Message-ID: <YFyDARFZZUCG5LGc@osiris> (raw)
In-Reply-To: <CAEemH2cSk=doHL51uD5Qu6uCRRTCgYd0EN0iij=X+538J53XsQ@mail.gmail.com>
On Thu, Mar 25, 2021 at 04:56:18PM +0800, Li Wang wrote:
> Hi Heiko,
>
> On Wed, Mar 24, 2021 at 5:58 AM Heiko Carstens <hca@linux.ibm.com> wrote:
>
> > Li Wang reported that clock_gettime(CLOCK_MONOTONIC_RAW, ...) does not
> > work correctly on s390 via vdso. Debugging this also revealed an
> > unrelated bug (first patch).
> >
> > The second patch fixes the problem: the tod clock steering parameters
> > required by __arch_get_hw_counter() are only present within the first
> > element of the _vdso_data array and not at all within the _timens_data
> > array.
> >
> > Instead of working around this simply provide an s390 specific vdso
> > data page which contains the tod clock steering parameters.
> >
> > This allows also to remove ARCH_HAS_VDSO_DATA again.
> >
> > Heiko Carstens (3):
> > s390/vdso: fix tod clock steering
> > s390/vdso: fix arch_data access for __arch_get_hw_counter()
> > lib/vdso: remove struct arch_vdso_data from vdso data struct
> >
>
> Thanks for the quick fix! I confirmed these patches work for me.
> (tested with latest mainline kernel v5.12-rc4)
>
> Tested-by: Li Wang <liwang@redhat.com>
Thanks a lot for confirming! However I decided to go with the simple variant:
https://lore.kernel.org/linux-s390/YFnxr1ZlMIOIqjfq@osiris/T/#m26f94fd8ac048421a4a8870e7259a09f97840a3e
May I add your Tested-by there as well?
next prev parent reply other threads:[~2021-03-25 12:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 6:21 [LTP] [s390x vDSO Bug?] clock_gettime(CLOCK_MONOTONIC_RAW, ...) gets abnormal ts value Li Wang
2021-03-23 7:11 ` Heiko Carstens
2021-03-23 13:48 ` Heiko Carstens
2021-03-23 21:58 ` [LTP] [PATCH 0/3] s390 vdso fixes Heiko Carstens
2021-03-23 21:58 ` [LTP] [PATCH 1/3] s390/vdso: fix tod clock steering Heiko Carstens
2021-03-24 9:50 ` Heiko Carstens
2021-03-23 21:58 ` [LTP] [PATCH 2/3] s390/vdso: fix arch_data access for __arch_get_hw_counter() Heiko Carstens
2021-03-24 5:53 ` Heiko Carstens
2021-03-23 21:58 ` [LTP] [PATCH 3/3] lib/vdso: remove struct arch_vdso_data from vdso data struct Heiko Carstens
2021-03-25 17:55 ` Thomas Gleixner
2021-03-25 17:57 ` Thomas Gleixner
2021-03-25 8:56 ` [LTP] [PATCH 0/3] s390 vdso fixes Li Wang
2021-03-25 12:33 ` Heiko Carstens [this message]
2021-03-25 14:11 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFyDARFZZUCG5LGc@osiris \
--to=hca@linux.ibm.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox