From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] realtime/scripts: Fix indentation error in parser.py
Date: Thu, 1 Apr 2021 08:35:26 +0200 [thread overview]
Message-ID: <YGVprik5olSjhY+n@pevik> (raw)
In-Reply-To: <20210329181759.4466-1-sturlapati@vmware.com>
Hi Sharan,
> An indentation error in parser.py causes certain blocks
> of code to run even before dependent variables are
> initialized when the code in this file is imported
> by parse-testpi1.py or parse-testpi2.py.
> Post running tests like testpi-2 or testpi-4, the
> results of these tests are parsed and added to the
> logs/ directory. This bug prevents the results of such
> tests from being parsed and thus masks the results of
> these tests.
Thanks for your fix, merged!
It looks to me that 5a8408bc3 changed also whitespace in other files (it was
done by 2to3 script), but these are IMHO correct.
BTW looking into realtime sources, the code is terrible. Not sure how relevant
it is now.
Kind regards,
Petr
next prev parent reply other threads:[~2021-04-01 6:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 18:17 [LTP] [PATCH] realtime/scripts: Fix indentation error in parser.py Sharan Turlapati
2021-04-01 6:35 ` Petr Vorel [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-03-25 18:21 Sharan Turlapati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGVprik5olSjhY+n@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox