From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] syscalls/unshare: convert unshare02 to the new API
Date: Mon, 19 Apr 2021 16:07:43 +0200 [thread overview]
Message-ID: <YH2OrwsqdO231sNB@yuki> (raw)
In-Reply-To: <20210419122246.7706-3-xieziyao@huawei.com>
Hi!
> 1. Convert unshare02 to the new API;
> 2. Check whether the returned value is correct in the child process
> instead of the parent process;
> 3. Add a test case: use the CLONE_NEWNS parameter as a non-root user
> and the expected return value is EPERM.
The EPERM check fails if the test is executed by a root. LTP tests
usually setuid() to "nobody" for EPERM tests if executed as a root.
The TC should be lowercase but that is very minor.
Apart from these it's a really good cleanup.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2021-04-19 14:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 12:22 [LTP] [PATCH 0/2] syscalls/unshare: convert unshare to the new API Xie Ziyao
2021-04-19 12:22 ` [LTP] [PATCH 1/2] syscalls/unshare: convert unshare01 " Xie Ziyao
2021-04-19 14:02 ` Cyril Hrubis
2021-04-19 12:22 ` [LTP] [PATCH 2/2] syscalls/unshare: convert unshare02 " Xie Ziyao
2021-04-19 14:07 ` Cyril Hrubis [this message]
2021-04-20 7:36 ` xieziyao
2021-04-20 7:29 ` [LTP] [PATCH v2] syscalls/unshare: Convert " Xie Ziyao
2021-04-20 9:36 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YH2OrwsqdO231sNB@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox