From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] mkfs: print more info for debugging
Date: Tue, 20 Apr 2021 10:22:39 +0200 [thread overview]
Message-ID: <YH6PT2HKt6t1xZxR@pevik> (raw)
In-Reply-To: <20210420075351.16059-1-liwang@redhat.com>
> We can NOT reproduce the problem by manual with both ppc64le and s390x,
> so let's print more useful info from test when getting fail.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
LGTM, just some remarks below
> mkfs01 1 TPASS: 'mkfs -t ext4 /dev/loop0 ' passed.
> mkfs01 2 TFAIL: 'mkfs -t ext4 /dev/loop0 16000' failed, not expected.
> mkfs01 3 TPASS: 'mkfs -t ext4 -c /dev/loop0 ' passed.
> mkfs01 4 TPASS: 'mkfs -V ' passed.
> mkfs01 5 TPASS: 'mkfs -h ' passed.
> Signed-off-by: Li Wang <liwang@redhat.com>
> ---
> testcases/commands/mkfs/mkfs01.sh | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
> diff --git a/testcases/commands/mkfs/mkfs01.sh b/testcases/commands/mkfs/mkfs01.sh
> index 90368190d..55296c8df 100755
> --- a/testcases/commands/mkfs/mkfs01.sh
> +++ b/testcases/commands/mkfs/mkfs01.sh
> @@ -128,7 +128,8 @@ mkfs_test()
> if [ -n "$device" ]; then
> mkfs_verify_type "$fs_type" "$device"
> if [ $? -ne 0 ]; then
> - tst_res TFAIL "'${mkfs_cmd}' failed, not expected."
> + tst_res TFAIL "'${mkfs_cmd}' failed, not expected type."
Maybe "unexpected type"?
I'd also change ${mkfs_cmd} to $mkfs_cmd (more readable).
> + cat temp
> return
> fi
> fi
> @@ -136,7 +137,8 @@ mkfs_test()
> if [ -n "$size" ]; then
> mkfs_verify_size "$fs_type" "$size"
> if [ $? -ne 0 ]; then
> - tst_res TFAIL "'${mkfs_cmd}' failed, not expected."
> + tst_res TFAIL "'${mkfs_cmd}' failed, not expected size."
The same here.
Kind regards,
Petr
> + cat temp
> return
> fi
> fi
next prev parent reply other threads:[~2021-04-20 8:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 7:53 [LTP] [PATCH] mkfs: print more info for debugging Li Wang
2021-04-20 8:22 ` Petr Vorel [this message]
2021-04-20 8:39 ` Li Wang
2021-04-20 12:17 ` Jan Stancek
2021-04-20 13:01 ` Li Wang
2021-04-20 13:09 ` Jan Stancek
2021-04-21 10:46 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YH6PT2HKt6t1xZxR@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox