From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 3/4] lib: Apply the skip_filesystems to rest of test as well
Date: Tue, 13 Apr 2021 13:51:29 +0200 [thread overview]
Message-ID: <YHWFwWeT7IsJKsFf@yuki> (raw)
In-Reply-To: <b2d54281-2893-2dc1-e2a8-ff789dc1c1f2@suse.cz>
Hi!
> > + if (tst_fs_in_skiplist(fs_name, tst_test->skip_filesystems)) {
> > + tst_brk(TCONF, "Skipping %s as requested by the test",
> > + fs_name);
>
> This message might be a little confusing when the test didn't ask for
> all filesystems. I'd recommend something like "Test does not support %s
> workdir, skipping". The else clause below is probably unnecessary.
I've adjusted the message to "%s is not supported by the test" and fixed
the enum name as reported by Li and pushed the patchset.
Thanks a lot for the reviews.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2021-04-13 11:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 10:53 [LTP] [PATCH v3 0/4] Add proper filesystem skiplist Cyril Hrubis
2021-03-17 10:53 ` [LTP] [PATCH v3 1/4] lib: " Cyril Hrubis
2021-04-08 8:18 ` Li Wang
2021-04-08 8:48 ` Cyril Hrubis
2021-04-08 9:27 ` Li Wang
2021-03-17 10:53 ` [LTP] [PATCH v3 2/4] lib: tst_fs_type change fs names to lowercase Cyril Hrubis
2021-03-17 10:53 ` [LTP] [PATCH v3 3/4] lib: Apply the skip_filesystems to rest of test as well Cyril Hrubis
2021-03-17 11:53 ` Martin Doucha
2021-04-13 11:51 ` Cyril Hrubis [this message]
2021-03-17 10:53 ` [LTP] [PATCH v3 4/4] doc: Update docs on filesystem detection Cyril Hrubis
2021-03-18 10:21 ` [LTP] [PATCH v3 0/4] Add proper filesystem skiplist Petr Vorel
2021-04-07 12:57 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHWFwWeT7IsJKsFf@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox