From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] bugfix for iso9660/isofs.sh
Date: Tue, 13 Apr 2021 22:27:41 +0200 [thread overview]
Message-ID: <YHX+vS+SnHJt7mDi@pevik> (raw)
In-Reply-To: <20210407052424.5795-1-zhanglianjie@uniontech.com>
Hi,
...
> Thank you very much for your guidance, but I want to submit it myself.
> Because this is the first time I submit a patch in the community.
I added this as your commit and merged. But please next time send a proper patch
(it's easier to use proper patch via LTP patchwork [1]).
And I added additional cleanup patch.
Kind regards,
Petr
[1] https://patchwork.ozlabs.org/project/ltp/list/
> ---
> testcases/kernel/fs/iso9660/isofs.sh | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
> diff --git a/testcases/kernel/fs/iso9660/isofs.sh b/testcases/kernel/fs/iso9660/isofs.sh
> index 9de3f7cdc..c0e2d1ff8 100755
> --- a/testcases/kernel/fs/iso9660/isofs.sh
> +++ b/testcases/kernel/fs/iso9660/isofs.sh
> @@ -9,14 +9,26 @@
> # It makes ISO9660 file system with different options and also
> # mounts ISO9660 file system with different mount options.
> -TST_NEEDS_CMDS="mkisofs"
> TST_NEEDS_TMPDIR=1
> TST_TESTFUNC=do_test
> +TST_SETUP=setup
> +
> . tst_test.sh
> MAX_DEPTH=3
> MAX_DIRS=4
> +setup()
> +{
> + if tst_cmd_available mkisofs; then
> + MKISOFS_CMD="mkisofs"
> + elif tst_cmd_available genisoimage; then
> + MKISOFS_CMD="genisoimage"
> + else
> + tst_brk TCONF "please install mkisofs or genisoimage"
> + fi
> +}
> +
> gen_fs_tree()
> {
> local cur_path="$1"
> @@ -56,7 +68,7 @@ do_test() {
> "-allow-lowercase -allow-multidot -iso-level 3 -f -l -D -J -allow-leading-dots -R"
> do
> rm -f isofs.iso
> - EXPECT_PASS mkisofs -o isofs.iso -quiet $mkisofs_opt $make_file_sys_dir 2\> /dev/null \
> + EXPECT_PASS $MKISOFS_CMD -o isofs.iso -quiet $mkisofs_opt $make_file_sys_dir 2\> /dev/null \
> || continue
> for mount_opt in \
next prev parent reply other threads:[~2021-04-13 20:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 5:24 [LTP] [PATCH] bugfix for iso9660/isofs.sh zhanglianjie
2021-04-13 20:27 ` Petr Vorel [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-04-07 2:31 zhanglianjie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHX+vS+SnHJt7mDi@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox