public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] controllers/memcg: Add testcase for kmem_limit_in_bytes of memory cgroup
Date: Wed, 14 Apr 2021 15:32:08 +0200	[thread overview]
Message-ID: <YHbu2LpnYB2J2Ey7@yuki> (raw)
In-Reply-To: <F3D3F6AC3820BB4C9FCA340DB5C32CB4038B5467@dggeml531-mbx.china.huawei.com>

Hi!
> BTW I find that the testcase run passed on my local system, it seems
> that tst_* will not trig memory allocation:

This is not, by any means, a proof that the test is correct.

"Passed on my machine" is nothing but poor excuse.

I can easily write utterly broken code that will work fine on a single
machine and fail on anything else. Correctly written test depends on
valid assumptions we can make about the operation system the test is
supposed to run on.

-- 
Cyril Hrubis
chrubis@suse.cz

  parent reply	other threads:[~2021-04-14 13:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-14 12:18 [LTP] [PATCH v2] controllers/memcg: Add testcase for kmem_limit_in_bytes of memory cgroup zhaogongyi
2021-04-14 13:31 ` Richard Palethorpe
2021-04-14 13:32 ` Cyril Hrubis [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-04-15  3:30 zhaogongyi
2021-04-14  8:19 zhaogongyi
2021-04-14 10:00 ` Richard Palethorpe
2021-04-14  6:40 zhaogongyi
2021-04-14  8:04 ` Richard Palethorpe
2021-04-13 12:29 zhaogongyi
2021-04-13 13:50 ` Richard Palethorpe
2021-04-12  8:44 Zhao Gongyi
2021-04-12 16:01 ` Richard Palethorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YHbu2LpnYB2J2Ey7@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox