public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/2] syscalls/chown: rewrite chown/chown01.c with the new api
Date: Fri, 16 Apr 2021 11:19:36 +0200	[thread overview]
Message-ID: <YHlWqG3x4Ea0EGfH@yuki> (raw)
In-Reply-To: <20210415063518.174631-2-xieziyao@huawei.com>

Hi!
Pushed with two changes, thanks.

> diff --git a/testcases/kernel/syscalls/chown/chown01.c b/testcases/kernel/syscalls/chown/chown01.c
> index 2e42153d6..c4898c53a 100644
> --- a/testcases/kernel/syscalls/chown/chown01.c
> +++ b/testcases/kernel/syscalls/chown/chown01.c
> @@ -1,179 +1,56 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
>  /*
>   * Copyright (c) 2000 Silicon Graphics, Inc.  All Rights Reserved.
> - *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of version 2 of the GNU General Public License as
> - * published by the Free Software Foundation.

Notice that the original code have been under GPL-2.0, we can't change
it to GPL-2.0-or-later unless we completely delete the test and write a
new one. So I've changed the SPDX to GPL-2.0.

> +/*\
> + * [Description]
>   *
> - * 	Cleanup:
> - * 	  Print errno log and/or timing stats if options given
> + * This is a Phase I test for the chown(2) system call. It is intended
> + * to provide a limited exposure of the system call, for now. It
> + * should/will be extended when full functional tests are written for
> + * chown(2).
>   *
> + * [Algorithm]
>   *
> - *#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#**/
> + * - Execute system call
> + * - Check return code, if system call failed (return=-1)
> + * -   Log the errno and Issue a FAIL message
> + * - Otherwise, Issue a PASS message
> + */

The description was way to verbose and the [Algorithm] was completely
useless and described the obvious. So I've shortened the description
before pushing.


-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2021-04-16  9:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15  6:35 [LTP] [PATCH v2 0/2] syscalls/chown: rewrite chown/chown{01, 03} with the new api Xie Ziyao
2021-04-15  6:35 ` [LTP] [PATCH v2 1/2] syscalls/chown: rewrite chown/chown01.c " Xie Ziyao
2021-04-16  9:19   ` Cyril Hrubis [this message]
2021-04-15  6:35 ` [LTP] [PATCH v2 2/2] syscalls/chown: rewrite chown/chown03.c " Xie Ziyao
2021-04-16  9:30   ` Cyril Hrubis
2021-04-19  1:45     ` xieziyao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YHlWqG3x4Ea0EGfH@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox