public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] realtime/func/pi-tests: testpi-2 parser indentation fix
Date: Mon, 3 May 2021 13:36:34 +0200	[thread overview]
Message-ID: <YI/gQjOJK3dtjiPr@pevik> (raw)
In-Reply-To: <1620029239-31643-1-git-send-email-ankitja@vmware.com>

Hi Ankit,

> There is an indentation issue in parser for testpi-2
> which causes incorect parsing of the logs.

Thanks for your fix, merged!

FYI the patch didn't apply, not sure why, I had to use patch to apply it
(instead of git am). I guess it was wrongly generated, please make sure
you use git format-patch properly.

If pi-tests are really working and worth to keep (one of my colleagues
realtime expert in the past didn't see much value in them), it'd be good
to rewrite these parsers to shell (to avoid unnecessary python3 dependency).

https://github.com/linux-test-project/ltp/issues/547

Also script assign True to flag variable but never uses it.

Kind regards,
Petr

  reply	other threads:[~2021-05-03 11:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-03  8:07 [LTP] [PATCH] realtime/func/pi-tests: testpi-2 parser indentation fix Ankit Jain
2021-05-03 11:36 ` Petr Vorel [this message]
2021-05-04 10:44   ` Ankit Jain
2021-05-04 11:00     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YI/gQjOJK3dtjiPr@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox