From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/sendfile: Delete unnecessary loop logic in do_child()
Date: Wed, 21 Apr 2021 14:35:23 +0200 [thread overview]
Message-ID: <YIAcC1DaWciwSypB@yuki> (raw)
In-Reply-To: <20210420133839.145408-1-xieziyao@huawei.com>
Hi!
Looking at the code the sendfile04 and sendfile05 does not need 99% of
the code in the tests, as a matter of fact it even breaks the tests with
sufficiently large -i parameter.
Can we please instead remove all the server and socket code from
sendfile04 and sendfile05? We can just easily pass in_fd and out_fd
pointing to a regular files to the sendfile() syscall instead.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2021-04-21 12:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 13:38 [LTP] [PATCH] syscalls/sendfile: Delete unnecessary loop logic in do_child() Xie Ziyao
2021-04-21 12:35 ` Cyril Hrubis [this message]
2021-04-22 7:13 ` xieziyao
2021-04-23 10:14 ` xieziyao
2021-04-23 13:32 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIAcC1DaWciwSypB@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox