Linux Test Project
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 3/3 v2] syscalls/close: Convert close08 to the new API
Date: Tue, 27 Apr 2021 14:23:33 +0200	[thread overview]
Message-ID: <YIgCRbFZ81vX4KfA@yuki> (raw)
In-Reply-To: <20210426125224.150268-4-xieziyao@huawei.com>

Hi!
Isn't this test just the same as close01.c?

I think that we can just remove close08.c since it does not add any more
coverage over close01.

Also we can add all kind of other file descriptor to the close01.c test
as well. We should add at least a few different socket fds there as well.

-- 
Cyril Hrubis
chrubis@suse.cz

      reply	other threads:[~2021-04-27 12:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26 12:52 [LTP] [PATCH 0/3 v2] syscalls/close: Convert close{01, 02, 08} to the new API Xie Ziyao
2021-04-26 12:52 ` [LTP] [PATCH 1/3 v2] syscalls/close: Convert close01 " Xie Ziyao
2021-04-27 12:15   ` Cyril Hrubis
2021-04-28  3:11     ` xieziyao
2021-04-26 12:52 ` [LTP] [PATCH 2/3 v2] syscalls/close: Convert close02 " Xie Ziyao
2021-04-27 12:20   ` Cyril Hrubis
2021-04-26 12:52 ` [LTP] [PATCH 3/3 v2] syscalls/close: Convert close08 " Xie Ziyao
2021-04-27 12:23   ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YIgCRbFZ81vX4KfA@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox