Linux Test Project
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] Ignore ntfs file system
Date: Tue, 27 Apr 2021 15:27:53 +0200	[thread overview]
Message-ID: <YIgRWZFymSmCKFyS@pevik> (raw)
In-Reply-To: <726f49eb-a185-6637-44e3-232d5e9b6fab@uniontech.com>

Hi,

> > > If the fuse file system is ignored and the kernel enable CONFIG_NTFS_FS,
> > > then the mount.ntfs of fuse is used when mounting ntfs,
> > > which is equivalent to not ignoring the fuse file system.

> > ...
> > > +++ b/testcases/kernel/syscalls/sync_file_range/sync_file_range02.c
> > > @@ -123,6 +123,7 @@ static struct tst_test test = {
> > >   	.all_filesystems = 1,
> > >   	.skip_filesystems = (const char *const []){
> > >   		"fuse",
> > > +		"ntfs",

> > Shouldn't "ntfs" *replace* "fuse"?
> Can't replace fuse.
Not sure if we understand each other: I mean add "ntfs" and *remove* "fuse",
as "fuse" is now redundant when we whitelist ntfs (see
tst_get_supported_fs_types()), unless there is problem with other fuse
filesystems. I tested with CONFIG_FUSE_FS=m CONFIG_EXFAT_FS=m.

But maybe removing "fuse" should be a separate step.

> > Testing on SLES kernel 5.3 (heavily patched) which is without CONFIG_NTFS_FS:
> > ...
> > tst_supported_fs_types.c:51: TINFO: mkfs.vfat does exist
> > ...
> > Summary:
> > passed   21
> > failed   0
> > broken   0
> > skipped  0
> > warnings 0
> If there is no CONFIG_NTFS_FS, the test of the ntfs file system will be
> ignored. Because there is fuse in skip_filesystems, the test can pass.

See above.

> > Testing Debian kernel 4.9.0-11-amd64 which is with CONFIG_NTFS_FS:
> > tst_supported_fs_types.c:148: TINFO: Skipping ntfs as requested by the test
> > ...
> > Summary:
> > passed   15
> > failed   0
> > broken   0
> > skipped  0
> > warnings 0

> CONFIG_NTFS_FS is configured, are you sure there is no ntfs
> in skip_filesystems? Why does it output "Skipping ntfs as requested by
> the test"?
> There should be no mount.ntfs command provided by ntfs-3g in your
> system.
See above.

Kind regards,
Petr

  reply	other threads:[~2021-04-27 13:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-25  3:04 [LTP] [PATCH] Ignore ntfs file system zhanglianjie
2021-04-26 19:25 ` Petr Vorel
2021-04-27 12:25   ` zhanglianjie
2021-04-27 13:27     ` Petr Vorel [this message]
2021-04-27 14:36       ` zhanglianjie
2021-04-27 19:14         ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YIgRWZFymSmCKFyS@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox