Linux Test Project
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] ttype: Replase TINFO with TPASS or TFAIL
Date: Wed, 28 Apr 2021 16:20:51 +0200	[thread overview]
Message-ID: <YIlvQ7D925aVJMao@yuki> (raw)
In-Reply-To: <20210428072016.17556-1-zhaogongyi@huawei.com>

Hi!
> diff --git a/testcases/kernel/syscalls/fcntl/fcntl16.c b/testcases/kernel/syscalls/fcntl/fcntl16.c
> index a77a81298..f12474f79 100644
> --- a/testcases/kernel/syscalls/fcntl/fcntl16.c
> +++ b/testcases/kernel/syscalls/fcntl/fcntl16.c
> @@ -673,10 +673,10 @@ int main(int ac, char **av)
>  		 */
>  		tst_resm(TINFO, "Entering block 1");
>  		if (run_test(O_CREAT | O_RDWR | O_TRUNC, 0777, 0, 11)) {
> -			tst_resm(TINFO, "Test case 1: without mandatory "
> +			tst_resm(TFAIL, "Test case 1: without mandatory "
>  				 "locking FAILED");
>  		} else {
> -			tst_resm(TINFO, "Test case 1: without manadatory "
> +			tst_resm(TPASS, "Test case 1: without manadatory "
>  				 "locking PASSED");
>  		}

I would be happier if we fixed the run_test() function to report
TFAIL/TPASS in all cases and just called run_test() from the main().

It shouldn't be even a big change since we report most of the failures
there, what we need is to change one TINFO into TFAIL and report TPASS
at the end of the function.

>  		tst_resm(TINFO, "Exiting block 1");

Also can we please get rid of the useless entering/exitting block
messages?


And the same applies for the rest of the tests changed by this patch.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2021-04-28 14:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28  7:20 [LTP] [PATCH] ttype: Replase TINFO with TPASS or TFAIL Zhao Gongyi
2021-04-28 14:20 ` Cyril Hrubis [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-04-29 13:05 zhaogongyi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YIlvQ7D925aVJMao@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox