From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 4/6] Add rtnetlink helper library
Date: Wed, 5 May 2021 14:16:36 +0200 [thread overview]
Message-ID: <YJKMpOi9Ei9z2cpy@yuki> (raw)
In-Reply-To: <YJKA9LQsiFDeuPUT@pevik>
Hi!
> > +int tst_rtnl_add_message(const char *file, const int lineno,
> > + struct tst_rtnl_context *ctx, const struct nlmsghdr *header,
> > + const void *payload, size_t payload_size)
> > +{
> > + size_t size;
> > + unsigned int extra_flags = 0;
> > +
> > + if (!tst_rtnl_grow_buffer(file, lineno, ctx, NLMSG_SPACE(payload_size)))
> Shouldn't there be an error message?
> Or maybe at tst_rtnl_grow_buffer() on if (!buf)
As far as I can tell we will get error message from the safe_realloc()
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Nice code, thanks!
>
> Kind regards,
> Petr
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2021-05-05 12:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 8:18 [LTP] [PATCH v3 1/6] Add SAFE_REALLOC() helper function to LTP library Martin Doucha
2021-05-05 8:18 ` [LTP] [PATCH v3 2/6] Add SAFE_RECV() " Martin Doucha
2021-05-10 7:55 ` Petr Vorel
2021-05-05 8:18 ` [LTP] [PATCH v3 3/6] Add SAFE_IOCTL() variant for library code Martin Doucha
2021-05-05 9:12 ` Cyril Hrubis
2021-05-10 7:57 ` Petr Vorel
2021-05-05 8:18 ` [LTP] [PATCH v3 4/6] Add rtnetlink helper library Martin Doucha
2021-05-05 10:17 ` Petr Vorel
2021-05-05 10:25 ` Martin Doucha
2021-05-05 11:24 ` Petr Vorel
2021-05-05 11:26 ` Petr Vorel
2021-05-05 12:16 ` Cyril Hrubis [this message]
2021-05-05 20:20 ` Petr Vorel
2021-05-05 13:15 ` Martin Doucha
2021-05-05 20:24 ` Petr Vorel
2021-05-05 12:14 ` Cyril Hrubis
2021-05-10 9:07 ` Petr Vorel
2021-05-05 8:18 ` [LTP] [PATCH v3 5/6] Add helper functions for managing network interfaces Martin Doucha
2021-05-05 12:39 ` Cyril Hrubis
2021-05-05 8:18 ` [LTP] [PATCH v3 6/6] Add test for CVE 2020-25705 Martin Doucha
2021-05-05 10:04 ` Petr Vorel
2021-05-05 10:33 ` Martin Doucha
2021-05-05 11:13 ` Petr Vorel
2021-05-05 13:06 ` Cyril Hrubis
2021-05-05 15:54 ` Martin Doucha
2021-05-10 7:42 ` [LTP] [PATCH v3 1/6] Add SAFE_REALLOC() helper function to LTP library Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJKMpOi9Ei9z2cpy@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox