public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 2/2] shell: Prevent orphan timeout sleep processes
Date: Fri, 7 May 2021 17:39:45 +0200	[thread overview]
Message-ID: <YJVfQanq/HPXnfi1@pevik> (raw)
In-Reply-To: <CAEemH2fgcFm4tsJdtj+J=sqvOy24w54QR+7M=Bhk2E7NDE68Gg@mail.gmail.com>

Hi Li,

> > > But there is another issue I found that the timeout03 can NOT
> > > be killed after timed out in calling cleanup(), the reason is
> > > tst_brk stop the _tst_kill_test running in the background so that
> > > it does not output as what we expected:
> > Good catch, I'll try to have a look as well.

> The simplest way I can think of is to let _tst_kill_test ignores
> the TERM and INT signals. If you agree to this, we can fix it in
> a separate patch:).

> --- a/testcases/lib/tst_test.sh
> +++ b/testcases/lib/tst_test.sh
> @@ -439,6 +439,8 @@ _tst_kill_test()
>  {
>         local i=10

> +       trap " " TERM INT
Acked-by: Petr Vorel <pvorel@suse.cz>

Thanks!

BTW I'm surprised " " works, I'd expect : would have to be used.

Kind regards,
Petr

  reply	other threads:[~2021-05-07 15:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-07 10:32 [LTP] [PATCH v2 0/3] shell: Fix orphan timeout sleep processes Joerg Vehlow
2021-05-07 10:32 ` [LTP] [PATCH v2 1/2] shell: Extend timeout tests Joerg Vehlow
2021-05-07 10:32 ` [LTP] [PATCH v2 2/2] shell: Prevent orphan timeout sleep processes Joerg Vehlow
2021-05-07 14:08   ` Li Wang
2021-05-07 14:22     ` Petr Vorel
2021-05-07 14:31       ` Li Wang
2021-05-07 15:39         ` Petr Vorel [this message]
2021-05-08  3:57           ` Li Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJVfQanq/HPXnfi1@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox