From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] netns_helper.sh: Fix parsing recent iproute2 versions
Date: Wed, 12 May 2021 13:42:39 +0200 [thread overview]
Message-ID: <YJu/L3HssZY14vQa@yuki> (raw)
In-Reply-To: <20210512103052.9646-1-pvorel@suse.cz>
Hi!
> diff --git a/testcases/kernel/containers/netns/netns_helper.sh b/testcases/kernel/containers/netns/netns_helper.sh
> index a5b77a0aa..4dac0e306 100755
> --- a/testcases/kernel/containers/netns/netns_helper.sh
> +++ b/testcases/kernel/containers/netns/netns_helper.sh
> @@ -47,16 +47,21 @@ IFCONF_IN6_ARG=
>
> tst_check_iproute()
> {
> - local cur_ipver="$(ip -V)"
> - local spe_ipver="$1"
> + local current_ver="$(ip -V)"
> + local expected_ver="111010"
So if I'm reading this right, this is 2010 again. I wonder if we can
just remove this check as well.
I guess that the most safe variant at the moment would be pushing this
patch, then dropping the check completely after the release.
> - cur_ipver=${cur_ipver##*s}
> + current_ver=${current_ver##*s}
>
> - if [ -z "$cur_ipver" -o -z "$spe_ipver" ]; then
> + if [ -z "$current_ver" ]; then
> tst_brk TBROK "failed to obtain valid iproute version"
> fi
>
> - if [ $cur_ipver -lt $spe_ipver ]; then
> + # new version scheme since v5.7.0-77-gb687d1067169
> + if echo "$current_ver" | grep -q 'iproute2-v\?[0-9]\+\.'; then
> + return
> + fi
> +
> + if [ $current_ver -lt $expected_ver ]; then
> tst_brk TCONF "too old iproute version"
> fi
> }
> --
> 2.31.1
>
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2021-05-12 11:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 10:30 [LTP] [PATCH 1/1] netns_helper.sh: Fix parsing recent iproute2 versions Petr Vorel
2021-05-12 11:42 ` Cyril Hrubis [this message]
2021-05-12 13:24 ` Petr Vorel
2021-05-12 14:04 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJu/L3HssZY14vQa@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox