From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] netns_helper.sh: Fix parsing recent iproute2 versions
Date: Wed, 12 May 2021 15:24:10 +0200 [thread overview]
Message-ID: <YJvW+spXh4za9v5p@pevik> (raw)
In-Reply-To: <YJu/L3HssZY14vQa@yuki>
Hi Cyril,
> Hi!
> > diff --git a/testcases/kernel/containers/netns/netns_helper.sh b/testcases/kernel/containers/netns/netns_helper.sh
> > index a5b77a0aa..4dac0e306 100755
> > --- a/testcases/kernel/containers/netns/netns_helper.sh
> > +++ b/testcases/kernel/containers/netns/netns_helper.sh
> > @@ -47,16 +47,21 @@ IFCONF_IN6_ARG=
> > tst_check_iproute()
> > {
> > - local cur_ipver="$(ip -V)"
> > - local spe_ipver="$1"
> > + local current_ver="$(ip -V)"
> > + local expected_ver="111010"
> So if I'm reading this right, this is 2010 again. I wonder if we can
> just remove this check as well.
Thanks for your input. FYI it's about iproute2 v3.0.0 (2011).
> I guess that the most safe variant at the moment would be pushing this
> patch, then dropping the check completely after the release.
I'm ok if we don't want to bother with this (and with patch for
netns_netlink.c [1]). But if you're ok to fix it for the release,
I'd send new patch which fixes it similar way as the fix for netns_netlink.c:
here just run "ip netns" to detect required support instead of checking version
info.
Kind regards,
Petr
[1] https://patchwork.ozlabs.org/project/ltp/patch/20210512100746.5907-1-pvorel@suse.cz/
next prev parent reply other threads:[~2021-05-12 13:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 10:30 [LTP] [PATCH 1/1] netns_helper.sh: Fix parsing recent iproute2 versions Petr Vorel
2021-05-12 11:42 ` Cyril Hrubis
2021-05-12 13:24 ` Petr Vorel [this message]
2021-05-12 14:04 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJvW+spXh4za9v5p@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox