[LTP] [PATCH v3 3/4] lib: ignore SIGINT in _tst_kill_test

Joerg Vehlow
2021-05-18T09:45:33Z

Hi,

On 5/18/2021 9:27 AM, Li Wang wrote:
> Hi Joerg,
>
>>> -trap "tst_brk TBROK 'test interrupted or timed out'" INT
>>> +trap "tst_brk TBROK 'test interrupted'" INT
>> This would require something like
>> trap "tst_brk TBROK 'test terminated'" TERM
>> or
>> trap "_tst_do_exit" TERM
>>
>> Otherwise the test is terminated very roughly, without executing
>> cleanup, which is probably not a good idea.
> Yes, seems I didn't realize this needs cleanup as well.
>
> But I'd still suggest keeping SIGINT here for catching Ctrl^C for users :).
+1, I never intended to remove thi
>> I am currently thinking about the following solution, to mitigate most
>> problems:
>> The timeout process sends SIGUSR1 (or maybe SIGALRM?) only to the main
>> test process and blocks TERM.
>> The main process can print, that it ran into a timeout, send a sigterm
>> to its processs group (while ignoring TERM itself).
>> Then it can unset $_tst_setup_timer_pid safely, because it knows it was
>> triggered by the timeout process and execute _tst_do_exit.
>>
>> If the timeout process does not see the termination of the main process,
>> it can still send SIGKILL to the whole process group.
>
> It probably will be work but looks a bit confusing since that involves
> more signals.
>
> In conclusion, I think we maybe have such situations to be solved:
>
> 1. SIGINT (Ctrl^C) for terminating the main process and do cleanup
> correctly before a timeout
> 2. Test finish normally and retrieves the _tst_timeout_process in the
> background via SIGTERM(sending by _tst_cleanup_timer)
> 3. Test timeout occurs and _tst_kill_test sending SIGTERM to
> terminating all process, and the main process do cleanup work
> 4. Test timeout occurs but still have process alive after
> _tst_kill_test sending SIGTERM, then sending SIGKILL to the whole
> group
>
> So, I'm now thinking can we just introduce a knob(variable) for skipping
> the _tst_cleanup_timer works in timeout mode, then it will not have a
> deadlock anymore.
This works of course and is the "simplest" solution, the only thing I do
not like about this,
is the fact, that SIGTERM send by something else (e.g. system shoutdown
or process manager),
is handled like timeouts are handled and reported as timeout. That's why
I suggested introducing
a new signal. But since this is probably rare, I could live without it.

>
> How about:
>
> --- a/testcases/lib/tst_test.sh
> +++ b/testcases/lib/tst_test.sh
> @@ -16,12 +16,14 @@ export TST_COUNT=1
> export TST_ITERATIONS=1
> export TST_TMPDIR_RHOST=0
> export TST_LIB_LOADED=1
> +export TST_TIMEOUT_OCCUR=0
>
> . tst_ansi_color.sh
> . tst_security.sh
>
> # default trap function
> -trap "tst_brk TBROK 'test interrupted or timed out'" INT
> +trap "tst_brk TBROK 'test interrupted'" INT
> +trap "TST_TIMEOUT_OCCUR=1; tst_brk TBROK 'test timeouted'" TERM
This could also be done by "unset _tst_setup_timer_pid" or
'_tst_setup_timer_pid=""'.
I guess even if a new variable is introduced, it should start with an _,
because it is supposed to be internal to the framework?

>
> _tst_do_exit()
> {
> @@ -48,7 +50,9 @@ _tst_do_exit()
> [ "$TST_TMPDIR_RHOST" = 1 ] && tst_cleanup_rhost
> fi
>
> - _tst_cleanup_timer
> + if ["$TST_TIMEOUT_OCCUR" = 0 ]; then
> + _tst_cleanup_timer
> + fi
>
> if [ $TST_FAIL -gt 0 ]; then
> ret=$((ret|1))
> @@ -439,18 +443,18 @@ _tst_kill_test()
> {
> local i=10
>
> - trap '' INT
> - tst_res TBROK "Test timeouted, sending SIGINT! If you are
> running on slow machine, try exporting LTP_TIMEOUT_MUL > 1"
> - kill -INT -$pid
> + trap '' TERM
> + tst_res TBROK "Test timeouted, sending SIGTERM! If you are
> running on slow machine, try exporting LTP_TIMEOUT_MUL > 1"
If you post this as a patch, can you please fix "timeouted" => "timed out"?
There is no word "timeouted" in the english language.

> + kill -TERM -$pid
> tst_sleep 100ms
>
> - while kill -0 $pid 2>&1 > /dev/null && [ $i -gt 0 ]; do
> + while kill -0 $pid >/dev/null 2>&1 && [ $i -gt 0 ]; do
> tst_res TINFO "Test is still running, waiting ${i}s"
> sleep 1
> i=$((i-1))
> done
>
> - if kill -0 $pid 2>&1 > /dev/null; then
> + if kill -0 $pid >/dev/null 2>&1; then
> tst_res TBROK "Test still running, sending SIGKILL"
> kill -KILL -$pid
> fi
>
>
> --
> Regards,
> Li Wang

@Petr
I wouldn't recommend getting the fix into the release.
The problem is nothing new and does not fix a "real issue" at the moment,
but has the risk of introducing something unexpected.
Fixing the output redirection could be done without a major risk, I guess.

J?rg