From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/statx04: use stx_attributes_mask before test
Date: Tue, 25 May 2021 16:16:08 +0200 [thread overview]
Message-ID: <YK0GqLg9AUrOxPdx@yuki> (raw)
In-Reply-To: <CAEemH2dxhzBk+fbR8YnxAKqQSYhsb=HW2B2rov18yOjk9a+5Uw@mail.gmail.com>
Hi!
> > stx_attributes_mask shows what's supported in stx_attributes.
> > Set supp_{append,compr,immutable,nodump} attributes only on filesystems
> > which actually support it.
> >
> > Also merge duplicate code.
> >
> > ---------------
> > v2->v3:
> > 1.add kernel version check for stx_attributes_mask
> > 2. use test_flag(int) instead of test_flagged and test_unflagged
> > ---------------
> >
> > Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> > Reviewed-by: Petr Vorel <pvorel@suse.cz>
>
> Reviewed-by: Li Wang <liwang@redhat.com>
>
> This patch makes sense to me, I'm not sure if any blocker issue for
> holding the apply process. If _no_ I would help to merge it:).
See:
https://github.com/linux-test-project/ltp/issues/557
Basically this change hides a kernel bug. I've proposed to create a
separate test for kernel that makes sure that all flags that are
supposed to be enabled are enabled for new enough kernels, then we can
apply this patch.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2021-05-25 14:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 10:34 [LTP] [PATCH] syscalls/statx04: use stx_attributes_mask before test Yang Xu
2019-08-02 11:50 ` Cyril Hrubis
2019-08-20 6:33 ` [LTP] [PATCH v2] " Yang Xu
2019-08-27 9:25 ` Petr Vorel
2019-08-27 9:58 ` Petr Vorel
2019-08-27 10:16 ` Cyril Hrubis
2019-09-11 10:22 ` =?unknown-8bit?b?WWFuZy/lvpAg5p2o?=
2019-09-11 12:47 ` Cyril Hrubis
2019-09-12 3:28 ` =?unknown-8bit?b?WWFuZy/lvpAg5p2o?=
2019-10-25 3:53 ` [LTP] [PATCH] " Yang Xu
2019-10-31 10:03 ` Yang Xu
2021-05-25 13:18 ` Li Wang
2021-05-25 14:16 ` Cyril Hrubis [this message]
2021-05-26 4:00 ` xuyang2018.jy
2021-05-26 8:31 ` Li Wang
2021-05-26 10:02 ` xuyang2018.jy
2021-11-10 13:28 ` Richard Palethorpe
2021-11-11 3:25 ` xuyang2018.jy
2019-08-28 3:56 ` [LTP] [PATCH v2] " Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK0GqLg9AUrOxPdx@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox